Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Rename BrowserState.queuedDownloads to BrowserState.downloads #7761

Closed
Amejia481 opened this issue Jul 17, 2020 · 2 comments
Closed

Rename BrowserState.queuedDownloads to BrowserState.downloads #7761

Amejia481 opened this issue Jul 17, 2020 · 2 comments
Assignees
@kglazko
Labels
<download> Component: feature-download 🌟 feature New functionality and improvements

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Jul 17, 2020 •
edited by data-sync-user
Loading

For supporting the download manger we want to expose all the downloads via the browser store not only the ones that are queued

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added 🌟 feature New functionality and improvements <download> Component: feature-download labels Jul 17, 2020
@Amejia481 Amejia481 changed the title Rename BrowserState.queuedDownloads to BrowserState.queuedDownloads Rename BrowserState.queuedDownloads to BrowserState.Downloads Jul 17, 2020
@Amejia481 Amejia481 mentioned this issue Jul 29, 2020
Closed
@Amejia481 Amejia481 changed the title Rename BrowserState.queuedDownloads to BrowserState.Downloads Rename BrowserState.queuedDownloads to BrowserState.downloads Jul 29, 2020
@Amejia481
Copy link
Contributor Author

Additionally we don't want to remove downloads from BrowserState.downloads when they are completed lets find all the places where we are dispatching RemoveQueuedDownloadAction and not dispatch the action when the download is completed.

@kglazko kglazko self-assigned this Jul 29, 2020
kglazko pushed a commit to kglazko/android-components that referenced this issue Jul 29, 2020
For mozilla-mobile#7761: Rename Queued Downloads And Persist
59085c3
kglazko pushed a commit to kglazko/android-components that referenced this issue Jul 29, 2020
For mozilla-mobile#7761: Rename Queued Downloads And Persist
37a72f8
kglazko pushed a commit to kglazko/android-components that referenced this issue Jul 30, 2020
For mozilla-mobile#7761: Rename Queued Downloads And Persist
1f4d45b
kglazko pushed a commit to kglazko/android-components that referenced this issue Jul 30, 2020
For mozilla-mobile#7761: Rename Queued Downloads And Persist
018b84e
bors bot pushed a commit that referenced this issue Jul 30, 2020
@MozLando
Merge #7911
165dd86 
7911: For #7761: Rename Queued Downloads And Persist r=Amejia481 a=kglazko



Co-authored-by: Kate Glazko <[email protected]>
@data-sync-user data-sync-user changed the title Rename BrowserState.queuedDownloads to BrowserState.downloads FNX3-22826 ⁃ Rename BrowserState.queuedDownloads to BrowserState.downloads Aug 5, 2020
@st3fan st3fan changed the title FNX3-22826 ⁃ Rename BrowserState.queuedDownloads to BrowserState.downloads Rename BrowserState.queuedDownloads to BrowserState.downloads Aug 5, 2020
@csadilek
Copy link
Contributor

This happened :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kglazko kglazko

Labels
<download> Component: feature-download 🌟 feature New functionality and improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csadilek @Amejia481 @kglazko