Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align inline buttons when 2 or more buttons are available #1321

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Align inline buttons when 2 or more buttons are available #1321

merged 2 commits into from
Jul 4, 2023

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Jul 4, 2023 •
edited
Loading

Changes

Align buttons that was still needed in rocky.

Issue link

Partially issue: #1135

Closes nothing

Proof

One of the examples:
image

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner July 4, 2023 10:11
@Rieven Rieven changed the title button alignments Align inline buttons when 2 or more buttons are available Jul 4, 2023
@underdarknl underdarknl merged commit 4ce28f5 into main Jul 4, 2023
@underdarknl underdarknl deleted the fix/button-alignments branch July 4, 2023 10:23
jpbruinsslot added a commit that referenced this pull request Jul 5, 2023
@jpbruinsslot
Merge branch 'main' into feature/mula/disabling-schedulers
c793ac2 
* main:
  Fix hanging worker processes on a SIGKILL (e.g. when the container is out of memory) (#1187)
  Remove unused method from DNSReport view (#1322)
  Rename pyc test files because they are overwritten (#1331)
  Add documentation about Config OOI's (#1307)
  Add Poetry configs for `bytes`, `boefjes`, `rocky`, and `mula` (#1295)
  Fix mermaid diagrams in docs for Bytes and Octopoes (#1311)
  Retrieve and store env and code hashes of a Boefje job (#1227)
  Mute Findings in bulk at Finding list (#1165)
  change TOC for usermanual (#1298)
  Add anchor tag to jump to after submitting the "set clearance level bulk form" on OOI list (#1315)
  Align inline buttons when 2 or more buttons are available (#1321)
  fix ooi form for netblocks (#1316)
  External asset database boefje (#1175)
  Change port classification bit to ip address (#1172)
  Handle RabbitMQ channel error in bytes (#1304)
  Fix object page ignoring the filters for JSON and CSV export (#1300)
dekkers pushed a commit that referenced this pull request Jul 17, 2023
@Rieven @dekkers
Align inline buttons when 2 or more buttons are available (#1321)
148319f
@dekkers dekkers mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underdarknl underdarknl underdarknl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rieven @underdarknl