Add anchor tag to jump to after submitting the "set clearance level bulk form" on OOI list #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistMeister
changed the title
underdarknl
approved these changes
Jul 4, 2023
Darwinkel
deleted the
feature/ooi-list-remember-page-position-after-submit
branch
jpbruinsslot
added a commit
that referenced
this pull request
Jul 5, 2023
* main: Fix hanging worker processes on a SIGKILL (e.g. when the container is out of memory) (#1187) Remove unused method from DNSReport view (#1322) Rename pyc test files because they are overwritten (#1331) Add documentation about Config OOI's (#1307) Add Poetry configs for `bytes`, `boefjes`, `rocky`, and `mula` (#1295) Fix mermaid diagrams in docs for Bytes and Octopoes (#1311) Retrieve and store env and code hashes of a Boefje job (#1227) Mute Findings in bulk at Finding list (#1165) change TOC for usermanual (#1298) Add anchor tag to jump to after submitting the "set clearance level bulk form" on OOI list (#1315) Align inline buttons when 2 or more buttons are available (#1321) fix ooi form for netblocks (#1316) External asset database boefje (#1175) Change port classification bit to ip address (#1172) Handle RabbitMQ channel error in bytes (#1304) Fix object page ignoring the filters for JSON and CSV export (#1300)
dekkers
pushed a commit
that referenced
this pull request
Jul 17, 2023
…ulk form" on OOI list (#1315) Co-authored-by: Patrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After submitting the bulk form ,the page scrolls back to the submit button again. As per request in #932. The downside is that the confirmation or error message gets "lost" since that sits at the top of the page. So I'm not quite sure if this is the way to go in terms of UX. At least not until we have a sticky notification. I already discussed this with @HeleenSG but that has yet to be implemented.
Issue link
Closes #932
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.