Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object page ignoring the filters for JSON and CSV export #1300

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Jun 28, 2023

Changes

I added a test for this and used the queryset instead of another connector.list().

Issue link

Closes #1095

Proof

See test


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner June 28, 2023 15:58
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, great test

@Darwinkel
Copy link
Contributor

Darwinkel commented Jun 29, 2023

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

  • Both CSV and JSON exports obey the (various combinations of) the search filters.
  • No apparent regressions

Bug or feature?:

  • Minor nitpick: the JSON and CSV exports do always state filters: All, which is presumably not the case ;)
    If it's an easy fix, then it would be nice to change this.

@underdarknl underdarknl merged commit 9ffbbf4 into main Jun 29, 2023
@underdarknl underdarknl deleted the fix/filter-export-object-list branch June 29, 2023 11:56
jpbruinsslot added a commit that referenced this pull request Jul 5, 2023
* main:
  Fix hanging worker processes on a SIGKILL (e.g. when the container is out of memory) (#1187)
  Remove unused method from DNSReport view (#1322)
  Rename pyc test files because they are overwritten (#1331)
  Add documentation about Config OOI's (#1307)
  Add Poetry configs for `bytes`, `boefjes`, `rocky`, and `mula` (#1295)
  Fix mermaid diagrams in docs for Bytes and Octopoes (#1311)
  Retrieve and store env and code hashes of a Boefje job (#1227)
  Mute Findings in bulk at Finding list (#1165)
  change TOC for usermanual (#1298)
  Add anchor tag to jump to after submitting the "set clearance level bulk form" on OOI list (#1315)
  Align inline buttons when 2 or more buttons are available (#1321)
  fix ooi form for netblocks (#1316)
  External asset database boefje (#1175)
  Change port classification bit to ip address (#1172)
  Handle RabbitMQ channel error in bytes (#1304)
  Fix object page ignoring the filters for JSON and CSV export (#1300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object list filter does not obey clearance level on export
4 participants