Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused method from DNSReport view #1322

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove unused method from DNSReport view #1322

merged 2 commits into from
Jul 5, 2023

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Jul 4, 2023

Changes

Found a view method that I could not find usages off.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner July 4, 2023 10:15
@Donnype Donnype self-assigned this Jul 5, 2023
@Donnype Donnype added the rocky Issues related to Rocky label Jul 5, 2023
@Darwinkel
Copy link
Contributor

No regressions during the onboarding.

@Darwinkel Darwinkel merged commit 0c9b034 into main Jul 5, 2023
@Darwinkel Darwinkel deleted the chore/remove-unused-method-to-get-dns-zone-for-url branch July 5, 2023 09:59
jpbruinsslot added a commit that referenced this pull request Jul 5, 2023
@jpbruinsslot
Merge branch 'main' into feature/mula/disabling-schedulers
c793ac2 
* main:
  Fix hanging worker processes on a SIGKILL (e.g. when the container is out of memory) (#1187)
  Remove unused method from DNSReport view (#1322)
  Rename pyc test files because they are overwritten (#1331)
  Add documentation about Config OOI's (#1307)
  Add Poetry configs for `bytes`, `boefjes`, `rocky`, and `mula` (#1295)
  Fix mermaid diagrams in docs for Bytes and Octopoes (#1311)
  Retrieve and store env and code hashes of a Boefje job (#1227)
  Mute Findings in bulk at Finding list (#1165)
  change TOC for usermanual (#1298)
  Add anchor tag to jump to after submitting the "set clearance level bulk form" on OOI list (#1315)
  Align inline buttons when 2 or more buttons are available (#1321)
  fix ooi form for netblocks (#1316)
  External asset database boefje (#1175)
  Change port classification bit to ip address (#1172)
  Handle RabbitMQ channel error in bytes (#1304)
  Fix object page ignoring the filters for JSON and CSV export (#1300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 approved these changes

@dekkers dekkers dekkers approved these changes

Assignees

@Donnype Donnype

Labels
rocky Issues related to Rocky
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Donnype @Darwinkel @dekkers @ammar92