Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tool to get/set job object resource limits #918

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Create tool to get/set job object resource limits #918

merged 1 commit into from
Jan 21, 2021

Conversation

katiewasnothere
Copy link
Contributor

@katiewasnothere katiewasnothere commented Dec 22, 2020 •
edited
Loading

This PR does the following:

  • Creates a tool to get/set job object resource limits called jobobject-util
  • Add new function to open existing job objects by name
  • Refactor's jobobject package's resource limit functions
  • Add two new winapi functions for dealing with job objects

This PR is part of the ongoing work for dynamic resource update. The jobobject-util tool will be used to get/set job object limits for process- and hypervisor- isolated containers.

Signed-off-by: Kathryn Baldauf [email protected]

@katiewasnothere katiewasnothere requested a review from a team as a code owner December 22, 2020 06:33
@katiewasnothere
Copy link
Contributor Author

@dcantah I'd especially like your feedback on this since you've been doing various job object work lately.

kevpar
kevpar reviewed Dec 22, 2020
View reviewed changes
cmd/jobobject-util/main.go Outdated Show resolved Hide resolved
@dcantah
Copy link
Contributor

dcantah commented Dec 22, 2020

I'll take a look at this more in the morning but I'd like to not have to pass handles around. If we can add an Open that returns the JobObject type (like Create) and expose the limit methods through here like we do for the others I'd prefer that.

And I know for containers you need to use NtOpenJobObject so maybe expose an NtOpen also, or have some logic on Open to decide which to use, either or.

dcantah
dcantah reviewed Dec 22, 2020
View reviewed changes
cmd/jobobject-util/main.go Outdated Show resolved Hide resolved
@katiewasnothere katiewasnothere force-pushed the job_object_limits_tool branch 3 times, most recently from 477b64e to bc47381 Compare January 13, 2021 20:02
dcantah
dcantah reviewed Jan 20, 2021
View reviewed changes
cmd/jobobject-util/main.go Outdated Show resolved Hide resolved
dcantah
dcantah reviewed Jan 20, 2021
View reviewed changes
cmd/jobobject-util/main.go Outdated Show resolved Hide resolved
dcantah
dcantah approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katiewasnothere katiewasnothere merged commit 4490e2e into microsoft:master Jan 21, 2021
@katiewasnothere katiewasnothere deleted the job_object_limits_tool branch January 21, 2021 21:12
@katiewasnothere katiewasnothere mentioned this pull request Jan 21, 2021
Merged
anmaxvl pushed a commit to anmaxvl/hcsshim that referenced this pull request Aug 19, 2021
@ambarve
Merged PR 4188258: update hcsshim ado to 43a75bb
80f5082 
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@katiewasnothere
Merge pull request microsoft#918 from katiewasnothere/job_object_limi…
5ec878d 
…ts_tool

Create tool to get/set job object resource limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevpar kevpar kevpar left review comments

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiewasnothere @dcantah @kevpar