Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for saving hcs compute system. #839

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

ambarve
Copy link
Contributor

@ambarve ambarve commented Jun 13, 2020

This is one of the many small PRs that enable the support for late cloning.
This PR simply adds the go wrappers required for saving a HCS compute system
which is used during template creation.

Signed-off-by: Amit Barve [email protected]

@ambarve ambarve changed the title Add support for saving hcs compute system. [Late_clone PR 1/5] Add support for saving hcs compute system. Jun 13, 2020
@dcantah
Copy link
Contributor

dcantah commented Jun 15, 2020

Talked offline about this but this one looks ready to go so can be undrafted :)

@ambarve ambarve marked this pull request as ready for review June 15, 2020 19:39
@ambarve ambarve requested a review from a team as a code owner June 15, 2020 19:39
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar
Copy link
Member

kevpar commented Jun 15, 2020

Rather than marking each PR with "[Late_clone PR N/5]", I would instead create a all-up tracking issue for late-clone with a list that links to each PR.

@ambarve ambarve changed the title [Late_clone PR 1/5] Add support for saving hcs compute system. Add support for saving hcs compute system. Jun 17, 2020
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

internal/hcs/system.go Outdated Show resolved Hide resolved
@dcantah
Copy link
Contributor

dcantah commented Aug 5, 2020

Is there anything blocking this? Besides looking into Kevins last comment

@ambarve ambarve force-pushed the user/ambarve/lcpr1_vmcompute branch from f976169 to 01f57e5 Compare August 18, 2020 22:28
@ambarve ambarve force-pushed the user/ambarve/lcpr1_vmcompute branch from 01f57e5 to 1558e2d Compare September 15, 2020 18:47
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambarve ambarve force-pushed the user/ambarve/lcpr1_vmcompute branch from 1558e2d to c112ff9 Compare December 23, 2020 22:08
This is one of the many small PRs that enable the support for late cloning.
This PR simply adds the go wrappers required for saving a HCS compute system
which is used during template creation.

Signed-off-by: Amit Barve <[email protected]>
This is one of the many small PRs that enable the support for late cloning.
This commit adds the template and clone creation support in the uvm module.

Signed-off-by: Amit Barve <[email protected]>
This is one of the many small PRs that enable the support for late cloning.
This commit adds the set of functions required for adding network namespace and
network endpoints to cloned UVMs.

Signed-off-by: Amit Barve <[email protected]>
This is one of the many small PRs that enable the support for late
cloning.This commit adds the set of functions that expose the late cloning
functionality from hcsshim and adds new annotations for clients to use
the late cloning feature.

Signed-off-by: Amit Barve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants