Add shimdiag flag to find shim process ID for shims #912
Conversation
|
Remembered I had a branch with a bunch of shimdiag additions and saw that there was an item in the backlog that had one of the things in the branch so shrugs haha. Not sure if this was what was envisioned for it or if it'd be preferred as its own command. |
|
Could you add a use case/motivation case to the description? |
|
@katiewasnothere done |
dcantah
force-pushed
the
improve-shimdiag
branch
from
6edc2f4 to
013d310
Compare
dcantah
force-pushed
the
improve-shimdiag
branch
from
013d310 to
2342cd9
Compare
cmd/shimdiag/list.go
Outdated
| } | ||
| fmt.Fprintf(w, "%s \t %d\n", shim, pid) | ||
| } else { | ||
| fmt.Println(shim) |
There was a problem hiding this comment.
Do you need to use the tabwriter here?
There was a problem hiding this comment.
Nope, here's the output of both:
PS C:\ContainerPlat> .\shimdiag.exe list
k8s.io-10ca615f457902b0a31252ad299f64bd22e0a09b309eb36e0bf5b61376f563b1
k8s.io-128d6078c12b8df8a219ef3569b7542f4d19cc3615f7ca7f130724a911e92d21
k8s.io-f5b13b1e43e3223f3591a5a4e20938643453a9fd88ad21eec0274e4b600abcc5
PS C:\ContainerPlat> .\shimdiag.exe list -pids
Shim Pid
k8s.io-10ca615f457902b0a31252ad299f64bd22e0a09b309eb36e0bf5b61376f563b1 48420
k8s.io-128d6078c12b8df8a219ef3569b7542f4d19cc3615f7ca7f130724a911e92d21 30272
k8s.io-f5b13b1e43e3223f3591a5a4e20938643453a9fd88ad21eec0274e4b600abcc5 17992
There was a problem hiding this comment.
Lovely formatting github, here's a pic instead.
There was a problem hiding this comment.
What's the point of making the tab writer then when pids is not specified? Might as well use it if it doesn't cause fformat issues
There was a problem hiding this comment.
No reason other than we have to make it before because we have to flush it after the loop so it can't be made inside.
* Adds a new -pids flag to the `shimdiag list` command that will print out the process ID of the shim executable. Sample output: PS C:\> shimdiag.exe list -pids Shim Pid k8s.io-3719754aab39925924b0beb27d2a195a4a6784c6ebe3690b81b2e7274a7021af 65892 k8s.io-908ea3697874891fd5814b1967515d3214257b65fc1974bdafd17276ee8ba3e5 69444 Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
improve-shimdiag
branch
from
2342cd9 to
e6272de
Compare
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Add shimdiag flag to find shim process ID for shims
-pidsflag to theshimdiag listcommand that will print out theprocess ID of the shim executable.
Use case would be to forcefully kill a shim if a pod was ever in a "stuck" state.
Sample output:
PS C:> shimdiag.exe list -pids
k8s.io-3719754aab39925924b0beb27d2a195a4a6784c6ebe3690b81b2e7274a7021af ==> 65892
k8s.io-908ea3697874891fd5814b1967515d3214257b65fc1974bdafd17276ee8ba3e5 ==> 69444
Signed-off-by: Daniel Canter [email protected]