Add HCS storage APIs #881
Merged
Add HCS storage APIs #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add information on what this is used for and how the bindings will be used in the future? |
|
@katiewasnothere Yep. Truth be told I opened the PR and went on an errand 😃 |
|
For the immediate future these bindings will be used to create a cache of scratch layers of different sizes to be used if a user asks for a scratch layer of a different size than the default that is made by the graph driver APIs (20GB). If the size requested is not in the cache, we will make a new scratch layer of that size using these binds as well. For the future, we may move containerd off of the old graphdriver (wclayer) calls and onto these for the windows snapshotter. No scenarios come to mind, but it gives more freedom in how layers are managed and especially how the writable layers are handled. |
ambarve
reviewed
Oct 27, 2020
ambarve
reviewed
Oct 27, 2020
ambarve
reviewed
Oct 27, 2020
ambarve
reviewed
Oct 27, 2020
dcantah
force-pushed
the
hcs-storage
branch
2 times, most recently
from
14e87c6 to
29760c7
Compare
ambarve
reviewed
Nov 4, 2020
|
One small suggestion but LGTM otherwise! |
|
Are these not in |
Correct |
kevpar
reviewed
Nov 6, 2020
* Add bindings for the HCS storage APIs from computestorage.dll Signed-off-by: Daniel Canter <[email protected]>
dcantah
added a commit
to dcantah/go-winio
that referenced
this pull request
Nov 10, 2020
This change adds bindings for AttachVirtualDisk and GetVirtualDiskPhysicalPath, some helper functions including one to create a differencing vhd, exports the create and open parameters, exports the create flags and adds a couple of missing flags. This will be used mainly to go hand in hand with the new computestorage calls added to hcsshim as all of the vhd creation and setup needs to be done manually for these calls. microsoft/hcsshim#881. Signed-off-by: Daniel Canter <[email protected]>
dcantah
added a commit
to dcantah/go-winio
that referenced
this pull request
Nov 20, 2020
This change adds bindings for AttachVirtualDisk and GetVirtualDiskPhysicalPath, some helper functions including one to create a differencing vhd, exports the create and open parameters, exports the create flags and adds a couple of missing flags. This will be used mainly to go hand in hand with the new computestorage calls added to hcsshim as all of the vhd creation and setup needs to be done manually for these calls. microsoft/hcsshim#881. Signed-off-by: Daniel Canter <[email protected]>
TBBle
reviewed
Nov 23, 2020
| // | ||
| // `layerPath` is a path to a directory containing the layer. | ||
| // | ||
| // `vhdHandle` is an empty file handle of `options.Type == OsLayerTypeContainer` |
There was a problem hiding this comment.
"empty file handle if" I think?
dcantah
added a commit
to dcantah/go-winio
that referenced
this pull request
Nov 25, 2020
This change adds bindings for AttachVirtualDisk and GetVirtualDiskPhysicalPath, some helper functions including one to create a differencing vhd, exports the create and open parameters, exports the create flags and adds a couple of missing flags. This will be used mainly to go hand in hand with the new computestorage calls added to hcsshim as all of the vhd creation and setup needs to be done manually for these calls. microsoft/hcsshim#881. Signed-off-by: Daniel Canter <[email protected]>
dcantah
added a commit
to dcantah/go-winio
that referenced
this pull request
Nov 25, 2020
This change adds bindings for AttachVirtualDisk and GetVirtualDiskPhysicalPath, some helper functions including one to create a differencing vhd, exports the create and open parameters, exports the create flags and adds a couple of missing flags. This will be used mainly to go hand in hand with the new computestorage calls added to hcsshim as all of the vhd creation and setup needs to be done manually for these calls. microsoft/hcsshim#881. Signed-off-by: Daniel Canter <[email protected]>
10 tasks
TBBle
referenced
this pull request
in nbdd0121/wsld
Nov 30, 2020
dcantah
added a commit
to dcantah/go-winio
that referenced
this pull request
Nov 30, 2020
This change adds bindings for AttachVirtualDisk and GetVirtualDiskPhysicalPath, some helper functions including one to create a differencing vhd, exports the create and open parameters, exports the create flags and adds a couple of missing flags. This will be used mainly to go hand in hand with the new computestorage calls added to hcsshim as all of the vhd creation and setup needs to be done manually for these calls. microsoft/hcsshim#881. Signed-off-by: Daniel Canter <[email protected]>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Canter [email protected]