Add new function to exec cmds in host for process isolated containers #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
internal/cmd/diag.go
Outdated
| @@ -34,3 +35,22 @@ func ExecInUvm(ctx context.Context, vm *uvm.UtilityVM, req *shimdiag.ExecProcess | |||
| err = cmd.Run() | |||
| return cmd.ExitState.ExitCode(), err | |||
| } | |||
|
|
|||
| func ExecInHost(ctx context.Context, req *shimdiag.ExecProcessRequest) (int, error) { | |||
There was a problem hiding this comment.
ExecOnHost sounds better to me but don't have strong feelings
There was a problem hiding this comment.
I changed it to ExecInShimHost, does that seem fair?
There was a problem hiding this comment.
More than fair, I like that more honestly 😃
katiewasnothere
force-pushed
the
argon_execinhost
branch
from
dc1f595 to
4822ebc
Compare
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
argon_execinhost
branch
from
4822ebc to
13f64b4
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function that allows us to exec commands on the container host of process isolated containers. This will be used in subsequent PRs to support resource modification of process isolated containers.
Signed-off-by: Kathryn Baldauf [email protected]