Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soroban to mainline, 0.41.0 release prep #532

Merged
merged 32 commits into from
Sep 19, 2023
Merged

Soroban to mainline, 0.41.0 release prep #532

merged 32 commits into from
Sep 19, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Sep 19, 2023

Merging the Soroban sdk support feature branch back into master.

This has gone through reviews already, only updated file in here is CHANGELOG.md

overcat and others added 26 commits July 21, 2023 10:27
…ay methods to the XDR classes. (#503)

* Update XDR, XDRGEN_COMMIT=472eac8c5609d310d48bd8eed68aa24d2626df53, XDRNEXT_COMMIT=e372df9f677961aac04c5a4cc80a3667f310b29f
Prepare `0.41.0-beta.0` for release
…otprintExpirationOperation. (#518)

* Fix the bug in Transaction.isSorobanTransaction to accommodate BumpFootprintExpirationOperation.

* remove "android-test" in deploy needs.

* Switch the system used for Android testing to macos-13.
* fix the issue of unable to parse liquidity_pool_revoked effect properly. (#521)

* add jitpack config.

* bump project version to upcoming 0.4.1

* update change log, include #522

* define `cursor`, `order` and `limit` in AssetsRequestBuilder object. (#522)
Revert "Remove the dependency on Guava. (#524)" (#533)

This reverts commit 302aba5.

Remove the dependency on Guava. (#524)
@sreuland
Copy link
Contributor Author

sreuland commented Sep 19, 2023

@overcat , thanks for getting #534 merged in, any other pr's that need to come in, such as #528 correct? you mentioned an issue related to operations effects that may have a fix needed also? Once finalized there, this PR should then be ready to merge soroban back to master and issue next mainline release including soroban support as 0.41.0.

@overcat
Copy link
Member

overcat commented Sep 19, 2023

@overcat , thanks for getting #534 merged in, any other pr's that need to come in, such as #528 correct? you mentioned an issue related to operations effects that may have a fix needed also? Once finalized there, this PR should then be ready to merge soroban back to master and issue next mainline release including soroban support as 0.41.0.

We should include #535, #537 and #528.

Should the next version be 0.41.0 or 0.41.0-beta4? I noticed that other software like horizon, rs-soroban-sdk, etc., have not yet released a stable version, so I think it should be 0.41.0-beta4? Is that correct?

@sreuland
Copy link
Contributor Author

Should the next version be 0.41.0 or 0.41.0-beta4? I noticed that other software like horizon, rs-soroban-sdk, etc., have not yet released a stable version, so I think it should be 0.41.0-beta4? Is that correct?

I heard some feedback that 0.41.0 was anticipated as next semver release since it would likely be the release to use with soroban on testnet, which will be upgrading to soroban/protcol 20 soon. Some other releases have started similar, horizon came out with 2.27.0 which has soroban, and some of the go sdks were released with soroban support like https://github.com/stellar/go/releases/tag/horizonclient-v12.0.0

@overcat
Copy link
Member

overcat commented Sep 19, 2023

Should the next version be 0.41.0 or 0.41.0-beta4? I noticed that other software like horizon, rs-soroban-sdk, etc., have not yet released a stable version, so I think it should be 0.41.0-beta4? Is that correct?

I heard some feedback that 0.41.0 was anticipated as next semver release since it would likely be the release to use with soroban on testnet, which will be upgrading to soroban/protcol 20 soon. Some other releases have started similar, horizon came out with 2.27.0 which has soroban, and some of the go sdks were released with soroban support like https://github.com/stellar/go/releases/tag/horizonclient-v12.0.0

Okay, then let's set the version to 0.41.0.

@tomerweller tomerweller merged commit 574b1f2 into master Sep 19, 2023
@overcat overcat deleted the soroban branch September 20, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants