Generate separate stellar-sdk-javadoc.jar release artifact

[overcat]

Closes #454

Note:
IDEA users need to enable the automatic download document function.
See https://intellij-support.jetbrains.com/hc/en-us/community/posts/206834305-Automatically-download-sources-documentation-from-maven-working-great

[sreuland]

looks good, can you add a test case in AssetsRequestBuilderTest to assert these new setters result in expected output fromAssetsRequestBuilder.buildUri() ?

[overcat]

We now have such a test. https://github.com/stellar/java-stellar-sdk/blob/305974255130a2ebe42aeb289ed7040de8d75892/src/test/java/org/stellar/sdk/requests/AssetsRequestBuilderTest.java#L18-L20

[overcat]

I just noticed that I mistakenly pushed the code from my other branch to this branch, so now the content of this PR has changed. I have updated the PR description. 🤦

So I think we need to re-review this PR, and if there are any issues, I will submit another PR to fix it.

[sreuland]

fortunately, this only merged to 'soroban' , should I revert the merge?

[overcat]

fortunately, this only merged to 'soroban' , should I revert the merge?

Before, in order to release the soroban version more conveniently, the changes related to migrating to GitHub Actions were also added to the soroban branch. This PR depends on this feature, so I tend to merge this PR into the soroban branch. However, due to my mistake, the latest one commit message in soroban is incorrect. It should be "Generate separate stellar-sdk-javadoc.jar release artifact" instead of "define cursor, order and limit in AssetsRequestBuilder object". so we can revert this PR and then reopen #520.

Sorry for any inconvenience caused.

[sreuland]

@overcat , since this is the last commit on soroban at present, we can avoid revert/redo, and instead I can git commit --amend -m "Generate separate stellar-sdk-javadoc.jar release artifact(#519)" , it will remove the prior commit hash and generate a new one with same changeset and the new message and then I can force push that to soroban`, is that ok to proceed?

[overcat]

@overcat , since this is the last commit on soroban at present, we can avoid revert/redo, and instead I can git commit --amend -m "Generate separate stellar-sdk-javadoc.jar release artifact(#519)" , it will remove the prior commit hash and generate a new one with same changeset and the new message and then I can force push that to soroban`, is that ok to proceed?

This is acceptable, can you update it in the soroban branch? thank you.

[sreuland]

@overcat , i pushed the change, please pull latest from soroban, if you had any dev branches in-progress that were off soroban will need to rebase them.