Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #512

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Aug 19, 2023

@overcat
Copy link
Member Author

overcat commented Aug 19, 2023

Can we consider merging the soroban branch into master? In this way, we can point all subsequent PRs to the master, otherwise we cannot automatically close the issue by merging PRs.

See: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#about-linked-issues-and-pull-requests

When you merge a linked pull request into the default branch of a repository, its linked issue is automatically closed. For more information about the default branch, see "Changing the default branch."

@sreuland
Copy link
Contributor

is the soroban branch backwards compatible for current mainline, might be doable then, as any other bug/patch fix on mainline can go through, otherwise probably less complex to keep on feature branch until we know next release will be the soroban enabled one.

@overcat
Copy link
Member Author

overcat commented Aug 21, 2023

is the soroban branch backwards compatible for current mainline, might be doable then, as any other bug/patch fix on mainline can go through, otherwise probably less complex to keep on feature branch until we know next release will be the soroban enabled one.

Thank you for pointing that out, let's keep it in the soroban branch.

@tamirms tamirms merged commit ea4e12c into lightsail-network:soroban Aug 21, 2023
@overcat overcat deleted the github-actions branch August 21, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants