fix the issue of unable to parse liquidity_pool_revoked effect properly. #521
Conversation
We have already added it in the soroban branch, but since we need to release it in the master branch now, let's add it again.
overcat
force-pushed
the
fix/issue/393
branch
from
ef17fc6 to
1911e94
Compare
There was a problem hiding this comment.
This file is irrelevant to this PR, please ignore it.
There was a problem hiding this comment.
This file is irrelevant to this PR, please ignore it.
There was a problem hiding this comment.
what issue or pr is it related to, this will land on master, is there a way to rebase the source branch to get cleaner change set?
There was a problem hiding this comment.
ok, I see it mentioned in the changelog notes, which is great, thanks!
|
It looks like this pr is also doing the release prep, as it has notes and version bump for 0.40.1, just to confirm, you intend to merge this and #522 to master and then we just tag release off master which would be an effective changeset of just those two, as nothing else has merged to master since 0.40.0 correct? |
Yes, let's merge these two PRs and then release it on the master branch. I have updated the changelog to include all the changes. |
| @@ -1318,4 +1321,96 @@ public void testDeserializeLiquidityPoolTradeEffect() { | |||
| new AssetAmount( | |||
| create("ARST:GB7TAYRUZGE6TVT7NHP5SMIZRNQA6PLM423EYISAOAP3MKYIQMVYP2JO"), "1.0000000")); | |||
| } | |||
|
|
|||
fix #393
Due to user demand for this fix, let's release it on the master branch.
Let's merge #522 first.