Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to verify if the SDK can be successfully integrated into an Android project. #514

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Aug 22, 2023

Closes #458

We have created an Android project that includes a simple invocation of the Stellar SDK. Afterwards, we run this app on the emulator to see if the app can function properly.
Screenshot_20230822_170241

@overcat overcat marked this pull request as draft August 22, 2023 11:20
@sreuland
Copy link
Contributor

want to mention #450 for additional background context on android

android usage raises more reason to consider okhttp alternatives since okhttp has kotlin deps that can conflict with kotlin in android runtimes.

@overcat overcat marked this pull request as ready for review August 23, 2023 06:31
@overcat
Copy link
Member Author

overcat commented Aug 23, 2023

The current dependencies used by the SDK have not been upgraded for a long time. This PR also helps us confirm that upgrading the dependencies will not cause disruptions.

@sreuland
Copy link
Contributor

The current dependencies used by the SDK have not been upgraded for a long time. This PR also helps us confirm that upgrading the dependencies will not cause disruptions.

yes, sound good for interim, the dependency modernization has been allocated to #496

@overcat
Copy link
Member Author

overcat commented Aug 23, 2023

Hi @sreuland, is there anything that needs to be changed in this PR, and if not, can we merge it?

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sreuland sreuland merged commit d6379e9 into lightsail-network:soroban Aug 23, 2023
@overcat overcat deleted the android-test branch September 13, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants