Links between SPA apps should not open a new tab

[indirectlylit]

Observed behavior

Navigate between facility and device settings pages	Explore without account

Related:

• https://kolibri-design-system.netlify.app/buttons/
• KButton, KExternalLink, KRouterLink should look identical with identical inputs kolibri-design-system#82
• learningequality/kolibri-design-system@29ba2b9

First noticed because in learningequality/kolibri-installer-gnome#7 for the GTK/webkit Gnome app, special handling had to be added so that "external links" which were actually internal links would be opened in a webkit window.

Expected behavior

From a user's perspective, the fact that different parts of Kolibri are implemented as separate SPAs is an implementation detail, not a feature. Navigating from one to the other should keep them in the same window.

• We should have a way of controlling whether or not links get opened in a new window
• Links that do get opened in a new window should include an icon, similar to that used in the design system:
• We should audit use of KExternalLink and ensure that cross-SPA links do not open in a new window

User-facing consequences

users are opening new tabs when they should be staying in the same tab

Steps to reproduce

Click 'explore without account'

Context

0.14.1

[nucleogenesis]

We should audit use of KExternalLink and ensure that cross-SPA links do not open in a new window

Bah I thought I did this :-(