Use of KExternalLink should never refer to Kolibri URLs, use KRouterLink

[nucleogenesis]

Observed behavior

The KDS KExternalLink component is supposed to be used for links outside of Kolibri. KRouterLink is supposed to link internally, even between SPAs.

Related to #7480 and the PRs/Issues that it refers to in the description.

Expected behavior

KExternalLink opens in a new tab and never links within Kolibri and every time we want this in Kolibri, we use KExternalLink
KRouterLink opens in the same tab/window and always links within Kolibri and we use KRouterLink everywhere that we link to Kolibri.

[jonboiser]

So, to fix this we should look for anything like this in the code:

<template>
   <KExternalLink :href="someLink">Link</KExternalLink>
</template>
<script>
import urls from 'kolibri.urls'

// Some where in the module, we're referencing something in urls:

computed: {
    someLink() {
        return urls['some:key:for:something']();
    }}
}
</script>

And replace it the KExternalLink with a KRouterLink which also supports an href prop.

[jonboiser]

Here are some places I think this change needs to be made. These are all usages of KExternalLink that point from one Kolibri plugin SPA to another.

Sign in link on AuthMessage

kolibri/kolibri/core/assets/src/views/AuthMessage.vue

Lines 13 to 18 in 4cf820b

	<KExternalLink
	:text="linkText"
	:href="signInLink"
	appearance="basic-link"
	/>
	</p>

Link from Coach -> Facility if there are no classes

kolibri/kolibri/plugins/coach/assets/src/views/CoachClassListPage.vue

Lines 27 to 32 in 4cf820b

	<KExternalLink
	v-if="isAdmin && createClassUrl"
	:text="$tr('noClassesDetailsForAdmin')"
	:href="createClassUrl"
	/>
	<span v-else>

Link from Device Settings -> Facility Settings

kolibri/kolibri/plugins/device/assets/src/views/DeviceSettingsPage/index.vue

Lines 10 to 15 in 4cf820b

	<KExternalLink
	v-if="!isMultiFacilitySuperuser && getFacilitySettingsPath()"
	:text="$tr('facilitySettings')"
	:href="getFacilitySettingsPath()"
	/>
	</p>

kolibri/kolibri/plugins/device/assets/src/views/DeviceSettingsPage/index.vue

Lines 85 to 98 in 4cf820b

	<section v-if="isMultiFacilitySuperuser">
	<h2>{{ $tr('configureFacilitySettingsHeader') }}</h2>
	<ul class="ul-reset">
	<template v-for="(facility, idx) in facilities">
	<li :key="idx">
	<KExternalLink
	:text="facility.name"
	:href="getFacilitySettingsPath(facility.id)"
	/>
	</li>
	</template>
	</ul>
	</section>
	</div>

Link from Facility Settings -> Device Settings

kolibri/kolibri/plugins/facility/assets/src/views/FacilityConfigPage/index.vue

Lines 9 to 14 in 4cf820b

	<KExternalLink
	v-if="isSuperuser && deviceSettingsUrl"
	:text="$tr('deviceSettings')"
	:href="deviceSettingsUrl"
	/>
	</p>

Link to device permissions page

kolibri/kolibri/plugins/facility/assets/src/views/UserEditPage.vue

Lines 39 to 45 in 4cf820b

	<KExternalLink
	v-if="devicePermissionsPageLink"
	class="super-admin-description"
	:text="editingSelf ? $tr('viewInDeviceTabPrompt') : $tr('changeInDeviceTabPrompt')"
	:href="devicePermissionsPageLink"
	/>

Link from Learn page to Content import page

kolibri/kolibri/plugins/learn/assets/src/views/ContentUnavailablePage.vue

Line 6 in 4cf820b

<KExternalLink v-if="deviceContentUrl" :text="$tr('adminLink')" :href="deviceContentUrl" />

[nucleogenesis]

Closing in favor of a different approach, opening a separate issue.