Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade design system (0.2.1) to fix external links #7483

Merged

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Aug 18, 2020

Summary

incorporates learningequality/kolibri-design-system#93

Reviewer guidance

related to #7480

reverts the new window behavior, but does not address the whole thing

References

also related - #7482


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Aug 18, 2020
@indirectlylit indirectlylit added this to the 0.14.2 milestone Aug 18, 2020
@indirectlylit indirectlylit added the changelog Important user-facing changes label Aug 18, 2020
@jonboiser jonboiser changed the title upgrade design system to fix external links upgrade design system (0.2.1) to fix external links Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #7483 into release-v0.14.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
kolibri/core/content/utils/annotation.py 88.61% <0.00%> (-1.22%) ⬇️
...ach/assets/src/modules/classSummary/dataHelpers.js 67.21% <0.00%> (-1.13%) ⬇️
kolibri/core/content/utils/sqlalchemybridge.py 80.97% <0.00%> (-1.08%) ⬇️
kolibri/utils/server.py 37.02% <0.00%> (-0.13%) ⬇️
...ns/coach/assets/src/modules/lessonSummary/index.js 13.33% <0.00%> (ø)
...learn/assets/src/views/AssessmentWrapper/index.vue 19.87% <0.00%> (ø)
...ibri/plugins/learn/assets/src/views/LearnIndex.vue 55.66% <0.00%> (+1.03%) ⬆️
...ns/learn/assets/src/views/ChannelCardGroupGrid.vue 21.05% <0.00%> (+1.05%) ⬆️
kolibri/utils/cli.py 66.05% <0.00%> (+1.31%) ⬆️

@jonboiser jonboiser merged commit 54ca9c8 into learningequality:release-v0.14.x Aug 18, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Aug 18, 2020
@indirectlylit indirectlylit deleted the design-system branch August 18, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants