-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links with target=_blank open outside Kolibri #7
Comments
dylanmccall
added a commit
that referenced
this issue
Aug 15, 2020
With this change, the "Open Link in New Window" context menu item behaves as expected, and links which open in new windows will work correctly. Issue #7
dylanmccall
added a commit
that referenced
this issue
Aug 15, 2020
In general, the desktop app should work in a single window. Closes #7
Merged
dylanmccall
added a commit
that referenced
this issue
Aug 17, 2020
With this change, the "Open Link in New Window" context menu item behaves as expected, and links which open in new windows will work correctly. Issue #7
Note that this particular behavior is actually a regression - opened a new issue here: learningequality/kolibri#7480 After that regression is fixed, we may need to revert #8 because there will actually be other scenarios where |
dylanmccall
pushed a commit
that referenced
this issue
Mar 25, 2022
Do not include search terms in topic nodes from kolibri URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kolibri sometimes has links with target=_blank, such as in the "Coach" section before any classes have been created:
Clicking one of these links in the app opens the default web browser. Instead, links like these (internal links which don't look like file downloads) should always open in the app, in the current window.
The text was updated successfully, but these errors were encountered: