Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KButton, KExternalLink, KRouterLink should look identical with identical inputs #82

Closed
nucleogenesis opened this issue Jul 22, 2020 · 2 comments
Closed

KButton, KExternalLink, KRouterLink should look identical with identical inputs #82

nucleogenesis opened this issue Jul 22, 2020 · 2 comments
Assignees
@sairina
Labels
category: library Shared code library type: proposal New feature or request

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented Jul 22, 2020 •
edited
Loading

I think that, perhaps, the only difference between them ought to really just be how we handle events.

  • KRouterLink takes a :to route which must be a valid router route.
  • KExternalLink takes a download prop (among others) to manage external URL links
  • KButton goes "click" if you click it and you can do what you want with that information.

All of them should have:

  • Primary or no?
  • Appearance basic-link raised-button flat-button
  • icon and iconAfter props & slots w/ a consistent sizing/styling
  • disabled prop

And I'm suggesting that If any of the components receive the same values for these props, they should look 100% identical. The only difference being how they act.
@nucleogenesis nucleogenesis added type: proposal New feature or request category: library Shared code library labels Jul 22, 2020
@nucleogenesis nucleogenesis added this to the upcoming major milestone Jul 22, 2020
nucleogenesis added a commit to nucleogenesis/kolibri that referenced this issue Jul 22, 2020
@nucleogenesis
'change user' back icon at password entry icon/layout fix
98e9022 
- Cannot use KRouterLink because it targets internally
- Want KRouterLink styles here, though, and I've had to hack
  that together with margins and my eyeballs
- KDS issue: learningequality/kolibri-design-system#82
  will track this in an upcoming release.
@indirectlylit
Copy link
Contributor

yes please

@indirectlylit indirectlylit mentioned this issue Aug 18, 2020
Closed
@sairina sairina removed this from the upcoming major milestone Feb 3, 2021
@sairina sairina self-assigned this Feb 11, 2021
@sairina sairina mentioned this issue Feb 11, 2021
Closed
@sairina
Copy link
Contributor

sairina commented Mar 19, 2021

Closing this issue, as it is continued in #166

@sairina sairina closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sairina sairina

Labels
category: library Shared code library type: proposal New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@indirectlylit @nucleogenesis @sairina