Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KExternalLink ought to open in new tab safely #94

Closed
nucleogenesis opened this issue Aug 18, 2020 · 1 comment · Fixed by #137 or #142
Closed

KExternalLink ought to open in new tab safely #94

nucleogenesis opened this issue Aug 18, 2020 · 1 comment · Fixed by #137 or #142
Labels
category: library Shared code library P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented Aug 18, 2020 •
edited
Loading

We removed the target="_blank" rel="noopener noreferrer" due to learningequality/kolibri#7480

However, KExternalLink ought to have a boolean prop openInNewTab when true will apply the proper attrs.

It also should be tested in Android and other special-build versions of Kolibri designed to run in a web view.

First, this must be finished: learningequality/kolibri#7482 because Kolibri uses KExternalLink for internal routing at time of writing.
@nucleogenesis nucleogenesis added this to the upcoming patch milestone Aug 18, 2020
@nucleogenesis nucleogenesis added category: library Shared code library P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri labels Aug 18, 2020
@sairina sairina mentioned this issue Dec 1, 2020
Merged
@indirectlylit
Copy link
Contributor

opened a follow-up issue for kolibri: learningequality/kolibri#7712

@sairina sairina mentioned this issue Dec 24, 2020
Merged
@sairina sairina linked a pull request Dec 24, 2020 that will close this issue
Update <KExternalLink> with icon and noopener noreferrer attr #142
Merged
@sairina sairina mentioned this issue Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: library Shared code library P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri
Projects
None yet
Milestone
No milestone
2 participants
@indirectlylit @nucleogenesis