-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean prop, 'openInNewTab' to KExternalLink #137
Conversation
Co-authored-by: Devon Rueckner <[email protected]>
@indirectlylit There is an issue for that #123 - One thing not noted in that issue is that we want it to be conditional upon the new @sairina maybe we could add the icon. You'll find the name of the icon here: https://kolibri-design-system.netlify.app/icons/#icons that you'll want to pass to the Additionally - we'll want to make sure that it displays with the correct color and on the right side of the link (just like in #123) - but when we're RTL it should show on the left side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to also add rel="noopener noreferrer"
attr to that <a>
tag for security purposes
https://mathiasbynens.github.io/rel-noopener/ has a great breakdown of why we need to add this to external links.
@nucleogenesis Thanks for that explanation! I'll add that in. |
Summary:
openInNewTab
toKExternalLink
:target
to anchor tag in<template>
to open up new tab ifopenInNewTab
is giventrue
Fixes #94
Testing: