-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Implementation Of KTable Component #727
Initial Implementation Of KTable Component #727
Conversation
KTable Initialisation
KTable - Week 2
KTable - Week 3
KTable - [Trial] Added changeSort event handler
[KTable] Accessibility for Loading States
Accessibility Testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BabyElias I read through the latest implementation and haven't noticed anything blocking, so I think we're ready :)! Well done.
Just leaving a few cleanup notes before merge.
Also I can see the linter check is failing, would you run yarn lint-fix
and commit?
any changes
Ran yarn lint-fix, still shows failing lint errors. |
@BabyElias can you try to run it multiple times locally until it shows no error? I don't know why but I needed to run it twice. It will make some changes to |
Caught few typos in the latest updates, but other than that, looks good! Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @BabyElias, let's release this :) Well done
Description
This PR introduces the
KTable
component to KDS. The component is a flexible and customizable table component designed to handle a variety of data presentation needs within our application. It supports advanced features such as local sorting, sticky headers, keyboard navigation, and dynamic column resizing, making it suitable for both simple and complex data tables.Issue addressed
328
330
Note to Reviewers :
tab
key andarrow
key navigations to move between the cells.width
andmin-width
props.Sortable table with external sorting method
. This external sorting can include cases where sorted data is fetched from backend, or use of custom sort functions with the table. An example of the same has been included in Playground page as Backend Sorted Table. In this example, clicking on any header will reverse the contents of the column - just an attempt to show the difference between external sorting and uselocalsorting.Changelog
KTable
componentSteps to test
Sample tables have been added on the Playground Page for testing.
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
After review
CHANGELOG.md
Comments