-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KTable]: Refactoring the handleKeydown method in KTable #795
Comments
Hi @MisRob , May I look into this one? |
Hi @shivam-daksh, thank you, I will assign you. Please have a look at a linked discussion to get a sense of direction and pay attention to acceptance criteria. |
@MisRob Sure I will. 😊 |
Lovely, thank you @shivam-daksh |
@shivam-daksh as soon as you open a PR, would you please mention @BabyElias there as well? She's the author of the table and interested in joining the reviews. Thank you! |
Hi @shivam-daksh, I wanted to mention that we will be closed from December 23 to January 5. It seems we will get to this QA rather next year, so hopefully then we can make progress toward merging all this wonderful work. Thanks! |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Summary
In #727, we introduced a new component—
KTable
—which provides a flexible, accessible table layout with enhanced keyboard navigation capabilities. As part of this, thehandleKeydown
method is responsible for managing keyboard navigation between table cells, handling focus, and managing the arrow, tab, and other keys.The current implementation of the
handleKeydown
method has grown more complex over time, making it harder to maintain and reason about. The goal of this issue is to refactor the method into a more readable and maintainable format, while preserving the functionality and accessibility of the keyboard navigation.The Value Add
KTable
component.Possible Tradeoffs
Potential performance considerations: although the goal is to refactor for readability, care should be taken to avoid performance regressions, especially when handling key events frequently during table navigation.
Guidance
Please refer to this discussion for a better understanding of the implementation. In Summary,
Acceptance Criteria
The text was updated successfully, but these errors were encountered: