-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default sort to KTable #794
Comments
Hey @MisRob, I would like to work on this? |
Hi @shivam-daksh, if this is still free after you resolve #795, message me again and we will assign you here too. #795 will be a good entry to familiarize yourself with |
Hi @MisRob , I would like to work on this issue |
Hey @iamnovaprince! Thanks for your interest in contributing to this issue. I will assign this to you. Please let us know if you have any question 🤗. |
Hi! I just wanted to confirm if this issue is being worked upon by @iamnovaprince right now or if the same is open for other contributors? |
Hi! , Due to some unforeseen work that came to me , I am not being able to give much time to the issue. Sorry for the inconvenience |
Hi! @iamnovaprince no need to apologize at all, thank you for considering volunteering your time, we appreciate it. @EshaanAgg seeing you showing up here gives me smiles and it'd be so wonderful to have you work on what @BabyElias has started and still continues! Welcome back and I hope to see you on Slack - let's chat how are you :) Regarding this work, I'm happy to assign you. Table has many keyboard and screen reader features - I would recommend to spend some time understanding the current implementation in detail. Let us know if you had any questions. |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Summary
Add a new feature to
KTable
that will allow the table to be sorted by default when initially loaded based on a chosen column. To achieve this:headers
will be expected to have a unique column identifiercolumnId
defaultSort
to receives a configuration object{ columnId, direction }
.columnId
references acolumnId
defined inheaders
. This specifies a column by which the table should be sorted when initially loaded.direction
can be'asc'
for ascending or'desc'
for descending sort direction.defaultSort
prop is not required.This feature is optional. The table should not be sorted by any column when initially loaded unless
defaultSort
is provided.Usage example
makes the table entries to be sorted by name in ascending direction when initially loaded.
Related tasks
Validation
KTable
throws a warning whencolumnId
is not present in any entry ofheaders
. This should be the case no matter of whetherdefaultSort
is used or not.KTable
throws a warning whendefaultSort
'sdirection
is a wrong value. Only allowed values are'asc'
and'desc'
.KTable
throws a warning whendefaultSort
'scolumnId
wasn't found inheaders
.Documentation
KTable
documentation examples are updated withcolumnId
inheaders
KTable
's documentation "Usage" section that explains this new featureReferences
Use-cases
Guidance
Acceptance criteria
KTable
usagesKTable
has new validations as specified aboveKTable
documentation page is updated as specified aboveThe text was updated successfully, but these errors were encountered: