Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIconButton: Set tooltip value as fallback if ariaLabel is missing #793

Closed
AlexVelezLl opened this issue Oct 3, 2024 · 3 comments
Closed
Assignees
Labels
Component: KIconButton good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal type: task Something that needs to be done

Comments

@AlexVelezLl
Copy link
Member

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Product

Kolibri, Studio, etc.

Description

In KIconButton we have these two props related but not exactly the same: ariaLabel and tooltip. For accessibility purposes we dont want these props to be the same, but if the user forgot to send an ariaLabel prop but they sent a tooltip prop, the ariaLabel should take the value of the tooltip prop.

This means, the aria label of the icon button will be set by the ariaLabel prop, and have the tooltip value as fallback if ariaLabel is missing.

The Value Add

This will improve accessibility in places where we have tooltips but no aria labels. And in the future we can just send the tooltip prop if we want the ariaLabel to have the same value.

@AlexVelezLl AlexVelezLl added type: task Something that needs to be done P3 - low Priority: Stretch goal Component: KIconButton good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome labels Oct 3, 2024
@shivam-daksh
Copy link
Contributor

@AlexVelezLl , Could you assign this to me?

@MisRob
Copy link
Member

MisRob commented Oct 7, 2024

Hi @shivam-daksh, thanks again. I will assign you this one alongside #795 so that you can switch tasks. Regarding other issues you volunteered for, let's leave it for later when these two are resolved.

@MisRob
Copy link
Member

MisRob commented Oct 9, 2024

Closed by #798

@MisRob MisRob closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: KIconButton good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal type: task Something that needs to be done
Projects
None yet
Development

No branches or pull requests

3 participants