any changes #5
Merged
any changes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the documentation page. Mounting as part of the KThemePlugin execution seems to work well after all.
that is performant and simple to use.
- The teleport root element is inserted to an application's
document body during KDS initialization
- Removes the need for manual insert
- Ensures we never attach teleported elements, such as tooltips,
to document.body itself, which is said to cause severe performance
problems (https://css-tricks.com/dont-attach-tooltips-to-document-body/)
- Adds new `KTeleport` component
- Wrapper around vue2-teleport with restricted API that only allows
teleporting to the KDS teleport root element.
- Removes Teleport in favour of KTeleport in KModal
- Adds appendToRoot prop to KTooltip
- In support of Studio migration to KDS where in a few instances,
teleport is needed for tooltips to display correctly
- Contains smaller refactor of Popper.vue to allow the tooltip
be attached to an element different from document.body
to be consistent with the overlay language in other components.
Fixes 'Invalid prop: type check failed for prop "appendToEl". Expected Object, got HTMLDivElement'
Trigger from event that has access to secrets. Update changelog formatting by converting string manipulation to Python.
…nvisible comment placeholder.
…e-comment Backport needed changes to automate changelog updates in release-v4
Automate changelog updates
Bumps [pug](https://github.com/pugjs/pug) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pugjs/pug/releases) - [Commits](https://github.com/pugjs/pug/compare/[email protected]@3.0.3) --- updated-dependencies: - dependency-name: pug dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…bot/npm_and_yarn/pug-3.0.3 Bump pug from 3.0.2 to 3.0.3
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7. - [Commits](indutny/elliptic@v6.5.4...v6.5.7) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…bot/github_actions/slackapi/slack-github-action-1.26.0 Bump slackapi/slack-github-action from 1.25.0 to 1.26.0
KCheckbox had local data which are initialized to the given props for
`indeterminate` and `checked` and then updated in a watcher. This
resulted in that clicking a checkbox would always toggle it's
`isCurrentlyChecked` value and setting `isCurrentlyIndeterminate` to
false.
The changes here instead have KCheckbox simply use the given prop values
and does nothing to manage any internal state around whether it shows
`indeterminate` and/or `checked`.
This results in users of KCheckbox needing to be mindful of how they
manage the values they pass into KCheckbox's props as the component will
now reflect their values at all time
Let's teleport + make 'sidebar' icon flip in RTL languages
update dropshadow to the latest guidelines
…hangelog Fix update changelog workflow and paste missing changelog item
…unopinionated KCheckbox: Remove local state management, rely on given props
Bump KDS version to 4.5.0
Bump KDS version to 5.0.0-rc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Addresses #PR# HERE
Before/after screenshots
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments