KTable - [Trial] Added changeSort event handler #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @BabyElias, this reflect well everything we talked about and am pretty confident that it will make the usage of the table for the Kolibri's facility users seamless ;) |
MisRob
approved these changes
Jun 14, 2024
MisRob
reviewed
Jun 14, 2024
| @@ -82,6 +88,25 @@ | |||
| } | |||
| }); | |||
|
|
|||
| watch( | |||
There was a problem hiding this comment.
Yes, this is an important piece to ensure reactivity
MisRob
reviewed
Jun 14, 2024
| }, | ||
| }); | ||
| const trElements = wrapper.findAll('tbody tr'); | ||
| expect(trElements.length).toBe(rows.length); | ||
| }); | ||
|
|
||
| it('should emit changeSort event on header click when useLocalSorting is false', async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description