Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTable Initialisation #647

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

BabyElias
Copy link
Contributor

Description

Initial PR for KTable Component under GSoC'24. This PR introduces dummy files for KTable component, documentation and testing.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@MisRob MisRob self-requested a review May 31, 2024 08:33
@MisRob MisRob self-assigned this May 31, 2024
}
.k-table table{
width:100%;
border:2px solid #ccc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes required, just a note that when we start getting to the final styles, hardcoded colors will never be used. Instead, tokens or palette colors will be used via computed styles as described at https://design-system.learningequality.org/colors. This will ensure that other themes will work (Kolibri can be themed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, noted!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MisRob
Copy link
Member

MisRob commented May 31, 2024

Hi @BabyElias, great start. Left one non-blocking comment and merging to the feature branch.

@MisRob MisRob merged commit ba89898 into learningequality:gsoc-table May 31, 2024
7 of 8 checks passed
@MisRob
Copy link
Member

MisRob commented May 31, 2024

Also, I assume you're using the playground page for visualization - feel free to always commit it as well to the feature gsoc-table branch. It will be handy for reviewers. We will clean the playground file shortly before gsoc-table -> develop merge which will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants