-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTable Initialisation #647
Conversation
} | ||
.k-table table{ | ||
width:100%; | ||
border:2px solid #ccc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes required, just a note that when we start getting to the final styles, hardcoded colors will never be used. Instead, tokens or palette colors will be used via computed styles as described at https://design-system.learningequality.org/colors. This will ensure that other themes will work (Kolibri can be themed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, noted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Hi @BabyElias, great start. Left one non-blocking comment and merging to the feature branch. |
Also, I assume you're using the playground page for visualization - feel free to always commit it as well to the feature |
Description
Initial PR for KTable Component under GSoC'24. This PR introduces dummy files for KTable component, documentation and testing.
Testing checklist
Reviewer guidance
After review
CHANGELOG.md
Comments