Init Polish localization

[mfilocha]

An initial config for Polish localization.

[sftim]

Am I right that this is a work-in-progress?

[sftim]

I think this PR should either:

• target a new branch, not master
• add Polski (pl) to disableLanguages

At the moment this pull request does not look OK to merge.

[sftim]

@mfilocha would you like help with, for example, getting a new branch made for the Polish work?

[mfilocha]

@sftim - @jimangel and @rlenferink asked me to reopen my previous PR against the master branch: #18254 (comment)

[rlenferink]

@sftim, we want to have this merged to master (our latest) branch as described by Jim as well. Why do you want to add pl to the disableLanguages? This PR adds all the initial configs and it will be a lot easier to translate and review when changes will be deployed for every PR.

As I understand @mfilocha processed all feedback from the previous pull request and then created this one. The only thing left to do is for @nvtkaszpir to request org membership (because OWNERS files are checked automatically) (@remyleone and me offered to sponsor).

[mfilocha]

@remyleone

[sftim]

This pull request does not yet add the minimum required content for a new localization. For that reason, it's not ready for approval.

According to the contribution guide, this new localization needs:

• A translation of the CNCF code of conduct into Polish
• A home page with all heading and subheading URLs
• A setup section - https://kubernetes.io/pl/docs/setup/ - with heading and subheading URLs
• The Kubernetes basics tutorial
• The Hello Minikube tutorial
• All site strings in a new localized TOML file

That's quite some work. So I'm recommending starting a new branch and working on making a series of changes to the new branch, until it is ready to merge into master.

[sftim]

@kubernetes/sig-docs-l10n-admins can you advise on whether I've [mis]understood?

[mfilocha]

I'll follow whatever is the recommended way.
My biggest concern is that the PR containing all translated minimum will be of XXL size. And who will review this PR for correctness/style of translation?

[sftim]

@mfilocha you're talking about the merge from the Polish localization dev branch into master? Because that XXL merge will consist only of already-approved changes, it won't need code review, just signoff.

For an example, see commit 487505d from PR #16551. I'm assuming that this single commit is the result of squashing a branch that includes many PRs (I haven't actually done one of these; that's what it looks like to me).

[remyleone]

I think targetting master is the way to go to start a localization and can be proven by the following successfully merged init localization: #12548 #16965

[remyleone]

@mfilocha got already a lot of content translated in Polish in his own fork ( https://github.com/mfilocha/website/tree/dev-1.16-pl.1 ).
My take would be to merge this initial PR as quickly as possible to make @mfilocha and the rest of the Polish translation team as autonomous as possible. Having this PR merged will make them able to quickly merge a lot of already made content that will be beneficial to the Polish-speaking users.

Slowing it down with extra requirements (that were not enforced for instance in the past of the Vietnamese translation) is not justified in this case IMHO.

@nvtkaszpir let me know when you open your org membership request, I will give my sponsoring to it.

[sftim]

Also see #17388

I agree: the current guidelines aren't clear, but there's a bug open to fix that.

[sftim]

@remyleone can I follow up on #18419 (comment) ?

#12548 looks like an example of a valid new localization, whereas it looks to me as if PR #16965 was merged too early (it should have waited on the changes that came in #17655). The Vietnamese localization team are doing a great job though, they've landed lots of good PRs since that first one.

@mfilocha I do not think that https://deploy-preview-18419--kubernetes-io-master-staging.netlify.com/pl/ looks good to merge; to me, this pull request looks like a strong work-in-progress. You can /retitle [WIP] Init Polish localization if you agree that there's more to do.

[mfilocha]

I wonder if dropping config.toml from this PR could help to avoid the scenario with the empty page as pointed by @sftim?
If I'm right this may allow us to follow the way set out by @remyleone in #18419 (comment).

[remyleone]

@sftim I disagree and think that a team should be able to show results as fast as possible and I'm not in favor of enforcing an arbitrary number of PR before they can have the gratification to see their work live. Wikipedia is a clear demonstration of this principle. Plus as you trust/empower a team as early as possible they have all agency to show other potential contributors that they can to quickly have an impact. All actions that delay the gratification of seeing your work in production should be removed in IMHO

[mfilocha]

PR to create a label for Polish language kubernetes/test-infra#15684 is on hold waiting for this PR to be merged.

[sftim]

To make https://deploy-preview-18419--kubernetes-io-master-staging.netlify.com/pl/ look right you need at least an _index.html page and to localize all the strings it uses.

The way I see it, the minimum guidelines do indeed cover what's necessary to get a sensible-looking preview rendering OK for a new localization.

There are 2 “essential” pages in the minimum requirements; one is Hello Minikube and the other is the Kubernetes basics tutorial. I can see why those are included, they are really useful for people new to Kubernetes. It's OK to launch a localization once those 2 pages are ready, even before the remaining hundreds of pages are ready to publish.

[mfilocha]

@sftim All required translated content is ready at my branch: master...mfilocha:dev-1.17-pl.1-master - I'm going to split it into smaller PRs for review.
But this should happen on a separate branch in the upstream repository, as soon as the localization team is established, I guess.

[sftim]

So it sounds to me that if an admin creates a new branch dev-1.17-pl.1 in this repo, @mfilocha you can send in pull requests that target that branch and that you're all ready to do that?

(and then those commits can merge into master in a single PR that does preview OK)

Have I got that right?

[mfilocha]

/assign @zacharysarah

[sftim]

@nvtkaszpir can you add /lgtm to this PR if you're happy with it? You're listed as a future reviewer.

[k8s-ci-robot]

@kpucynski: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nvtkaszpir]

/lgtm

[rlenferink]

2 times /lgtm by pl-reviewers. I think this is good to be merged @sftim 🎉

[jimangel]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jimangel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zacharysarah]

Congratulations! 🎉

[sftim]

/language pl