Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding i18n in Vietnamese #17655

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Adding i18n in Vietnamese #17655

merged 1 commit into from
Dec 12, 2019

Conversation

truongnh1992
Copy link
Member

Signed-off-by: Nguyen Hai Truong [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2019
@truongnh1992 truongnh1992 requested review from ngtuna and removed request for sftim and Rajakavitha1 November 19, 2019 09:45
@netlify
Copy link

netlify bot commented Nov 19, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6af276d

https://deploy-preview-17655--kubernetes-io-master-staging.netlify.com

@truongnh1992 truongnh1992 self-assigned this Nov 19, 2019
huynguyennovem
huynguyennovem reviewed Nov 20, 2019
View reviewed changes
i18n/vi.toml Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
@kubernetes kubernetes deleted a comment from k8s-ci-robot Nov 20, 2019
huynguyennovem
huynguyennovem approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@huynguyennovem huynguyennovem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@truongnh1992 truongnh1992 removed their assignment Nov 21, 2019
@huynguyennovem
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@truongnh1992
Copy link
Member Author

ping @jaredbhatti

@truongnh1992
Copy link
Member Author

@ngtuna could you help me to review this PR, please.

@truongnh1992
Copy link
Member Author

ping @remyleone
Could you help me to approve this PR. It has been approved by a owner Vietnamese localization K8s document.

@truongnh1992 truongnh1992 requested review from remyleone and removed request for ngtuna December 11, 2019 09:48
remyleone
remyleone reviewed Dec 11, 2019
View reviewed changes
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
i18n/vi.toml Outdated Show resolved Hide resolved
Adding VI i18n
e81574f 
Signed-off-by: Nguyen Hai Truong <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@truongnh1992
Copy link
Member Author

Thank @remyleone and @huynguyennovem for your review.
I've already resolved all of your comments.

@remyleone
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@truongnh1992
Copy link
Member Author

/assign @kbarnard10
Could you help me to approve this PR, please. It has been approved by a owner Vietnamese localization K8s document.

@truongnh1992 truongnh1992 self-assigned this Dec 11, 2019
@truongnh1992
Copy link
Member Author

/approve

@truongnh1992 truongnh1992 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: huynguyennovem, remyleone, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 422a2b0 into kubernetes:master Dec 12, 2019
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
@sftim sftim mentioned this pull request Jan 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@huynguyennovem huynguyennovem huynguyennovem approved these changes

Assignees

@remyleone remyleone

@kbarnard10 kbarnard10

@truongnh1992 truongnh1992

@huynguyennovem huynguyennovem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@truongnh1992 @huynguyennovem @remyleone @k8s-ci-robot @jaredbhatti @kbarnard10