Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init French translation #12548

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Init French translation #12548

merged 1 commit into from
Feb 13, 2019

Conversation

remyleone
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@netlify
Copy link

netlify bot commented Feb 8, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3e9c4ab

https://deploy-preview-12548--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 8, 2019
@remyleone
Copy link
Contributor Author

I've signed the individual agreement

@Rajakavitha1
Copy link
Contributor

/assign @xiangpengzhao

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@remyleone
Copy link
Contributor Author

remyleone commented Feb 11, 2019 •
edited
Loading

@perriea @rekcah78 @lledru @yastij @Smana @rbenzair would like to contribute as well to the French translation.

@remyleone remyleone force-pushed the language_fr branch 5 times, most recently from 30f50cc to 97a6815 Compare February 11, 2019 14:02
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2019
@remyleone remyleone force-pushed the language_fr branch 4 times, most recently from 5677e2b to db3570a Compare February 12, 2019 17:06
@zacharysarah
Copy link
Contributor

/assign @zacharysarah

lucperkins
lucperkins reviewed Feb 12, 2019
View reviewed changes
README-fr.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@zacharysarah
Copy link
Contributor

@sieben

I think I've added the relevant block to config.toml
Could you tell me what is missing?

It looks good to me. 💯

@zacharysarah zacharysarah mentioned this pull request Feb 12, 2019
Merged
@remyleone
Copy link
Contributor Author

How could it be merged now?

@zacharysarah
Copy link
Contributor

@sieben Just waiting on approval from a second reviewer. I've tagged @lucperkins; he'll get to it as his time permits.

@remyleone remyleone mentioned this pull request Feb 12, 2019
Closed
6 tasks
@yastij
Copy link
Member

yastij commented Feb 13, 2019

/hold

until @lucperkins reviews, I'll try to do a pass also on this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2019
@zparnold
Copy link
Member

zparnold commented Feb 13, 2019 via email

@perriea perriea mentioned this pull request Feb 13, 2019
Closed
6 tasks
@remyleone
Copy link
Contributor Author

@yastij I think @lucperkins did a review previously.

@lucperkins
Copy link
Contributor

LGTM

Or perhaps more appropriately TTBT (très très bon travail)

yastij
yastij approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit a5cda6e into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@remyleone
Init French translation (kubernetes#12548)
d766ab6
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@remyleone
Init French translation (kubernetes#12548)
66860b6
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@remyleone @yagonobre
Init French translation (kubernetes#12548)
d815a35
@remyleone remyleone deleted the language_fr branch April 2, 2019 14:01
@raelga raelga mentioned this pull request Apr 13, 2019
Merged
@rlenferink rlenferink mentioned this pull request Apr 17, 2019
Merged
@raelga raelga mentioned this pull request Oct 30, 2019
Closed
@remyleone remyleone mentioned this pull request Jan 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucperkins lucperkins lucperkins left review comments

@yastij yastij yastij approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@zacharysarah zacharysarah

@yastij yastij

@xiangpengzhao xiangpengzhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@remyleone @k8s-ci-robot @Rajakavitha1 @zacharysarah @yastij @zparnold @lucperkins @xiangpengzhao