-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portuguese translation - Content folder #13773
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 28c0399 https://deploy-preview-13773--kubernetes-io-master-staging.netlify.com |
/assign @Rajakavitha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @femrtnz. Welcome to Kubernetes Docs 🎉
Many thanks for initiating a Portugese translation of our docs.
Can you update the root OWNERS
as well to add the sig-docs-pt-reviews
and sig-docs-pt-owners
teams. You can have a look at the Spanish PR for more information:
https://github.com/kubernetes/website/pull/13543/files#diff-0de52d14f35759dfa67139f90c82bd7f
I signed it |
/checkcla |
@femrtnz If it is ready I would suggest to remove the WIP in the title of the PR |
@jcjesus What do you think about this PR? |
/checkcla |
Hi guys, I think is ok. but I will check and make comment as soon as possible. |
/check-cla |
@femrtnz There are some things still missing, like the Check the Spanish PR for reference: https://github.com/kubernetes/website/pull/13543/files#diff-7aeff2db0ead76e460e191a40bf9a0a9 or the French PR #12548. Don't hesitate to reach me in http://slack.kubernetes.io, I'll be glad to help. |
Thank you @raelga for the input. I just pushed the missing files now. Also, do you have any idea why the CLA step is still not passing? |
Great @femrtnz, thanks for the changes. About the CLA, just be sure that the user (mail address) you are using for the commits is the same as the one used in the CLA sign. Check https://git.k8s.io/community/CLA.md#the-contributor-license-agreement for more information. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @femrtnz !
I got a few points of feedback. Next to that it is necessary to add the Portuguese translation to the config.toml
otherwise Hugo won't pick it up.
You can have a look how to do that here:
https://github.com/kubernetes/website/pull/13543/files#diff-618063036395fe9ee107f22b46c9eade
No, my Github user id is jcjesus.
Em seg, 15 de abr de 2019 17:04, Roy Lenferink <[email protected]>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In OWNERS_ALIASES
<#13773 (comment)>:
> @@ -144,3 +144,8 @@ aliases:
- xichengliudui
- zhangxiaoyu-zidif
- pigletfly
+ sig-docs-pt-owners: # Admins for Portuguese content
+ - femrtnz
+ sig-docs-pt-reviews: # PR reviews for Portugese content
+ - femrtnz
+ - julio.jesus
I believe this should be juliojesus ***@***.***
<https://github.com/juliojesus>) ?
I might be wise to add Julio as sig-docs-pt-owner as well. Otherwise
someone from the English team has to approve your PRs @femrtnz
<https://github.com/femrtnz> ;) Of course we can do that, but it is
definitely good to grant approver privileges to other translators as well ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13773 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABufzBGjl4RMYfPzWqDkmGQSq_rDHrNDks5vhNtVgaJpZM4cpsIX>
.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @raelga @remyleone, Please let me know if there is anything else missing for this PR |
/lgtm |
/assign @zacharysarah |
@rlenferink Do you see something else? Could you approve this PR if it seems normal to you? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything else, we've got the initial setup covered in this PR ;)
Next steps
@femrtnz and @jcjesus, in the k/org repo please file an issue for k8s membership. More info here: https://kubernetes.io/docs/contribute/participating/#becoming-a-member
I'm happy to sponsor you and maybe @remyleone will chip in as well :)
After that, in the k/org repo, update sig-docs/teams.yaml
with a PR to:
- Add blocks for the owners and reviewers teams you created in
OWNERS_ALIASES
(example here). - Add the sig-docs-pt-owners individually to the
sig-docs-l10n-admins
team. - Add the sig-docs-pt-owners individually to the
website-milestone-maintainers
team.
/lgtm
/assign @zacharysarah
for approval
@femrtnz @jcjesus 👋 Thank you so much for starting this localization. The build preview looks great. ✨Welcome to Kubernetes! 🎉 @rlenferink @remyleone Thanks for providing reviews and guidance. 💛 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: remyleone, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initial creation of the content/pt folder