Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation - Content folder #13773

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Portuguese translation - Content folder #13773

merged 1 commit into from
Apr 16, 2019

Conversation

femrtnz
Copy link
Member

@femrtnz femrtnz commented Apr 11, 2019

Initial creation of the content/pt folder

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 11, 2019
@netlify
Copy link

netlify bot commented Apr 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28c0399

https://deploy-preview-13773--kubernetes-io-master-staging.netlify.com

@femrtnz
Copy link
Member Author

femrtnz commented Apr 11, 2019

/assign @Rajakavitha1

Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @femrtnz. Welcome to Kubernetes Docs 🎉
Many thanks for initiating a Portugese translation of our docs.

Can you update the root OWNERS as well to add the sig-docs-pt-reviews and sig-docs-pt-owners teams. You can have a look at the Spanish PR for more information:
https://github.com/kubernetes/website/pull/13543/files#diff-0de52d14f35759dfa67139f90c82bd7f

content/pt/OWNERS Outdated Show resolved Hide resolved
content/pt/OWNERS Outdated Show resolved Hide resolved
@femrtnz
Copy link
Member Author

femrtnz commented Apr 12, 2019

I signed it

@remyleone
Copy link
Contributor

/checkcla

content/pt/OWNERS Outdated Show resolved Hide resolved
@remyleone
Copy link
Contributor

@femrtnz If it is ready I would suggest to remove the WIP in the title of the PR

@remyleone
Copy link
Contributor

@jcjesus What do you think about this PR?

@femrtnz femrtnz changed the title WIP Portuguese translation - Content folder Portuguese translation - Content folder Apr 12, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2019
@femrtnz
Copy link
Member Author

femrtnz commented Apr 12, 2019

/checkcla

@jcjesus
Copy link
Contributor

jcjesus commented Apr 12, 2019

@jcjesus What do you think about this PR?

Hi guys, I think is ok. but I will check and make comment as soon as possible.

@raelga
Copy link
Member

raelga commented Apr 13, 2019

/check-cla

@raelga
Copy link
Member

raelga commented Apr 13, 2019

@femrtnz There are some things still missing, like the i18n/pt.toml file for Hugo and the README-pt.md for help newcomers join the sig-docs-pt team.

Check the Spanish PR for reference: https://github.com/kubernetes/website/pull/13543/files#diff-7aeff2db0ead76e460e191a40bf9a0a9 or the French PR #12548.

Don't hesitate to reach me in http://slack.kubernetes.io, I'll be glad to help.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2019
@femrtnz
Copy link
Member Author

femrtnz commented Apr 13, 2019

Thank you @raelga for the input. I just pushed the missing files now.

Also, do you have any idea why the CLA step is still not passing?

@raelga
Copy link
Member

raelga commented Apr 13, 2019

Great @femrtnz, thanks for the changes.

About the CLA, just be sure that the user (mail address) you are using for the commits is the same as the one used in the CLA sign. Check https://git.k8s.io/community/CLA.md#the-contributor-license-agreement for more information.

@femrtnz
Copy link
Member Author

femrtnz commented Apr 13, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 13, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2019
Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @femrtnz !

I got a few points of feedback. Next to that it is necessary to add the Portuguese translation to the config.toml otherwise Hugo won't pick it up.

You can have a look how to do that here:
https://github.com/kubernetes/website/pull/13543/files#diff-618063036395fe9ee107f22b46c9eade

README-pt.md Outdated Show resolved Hide resolved
README-pt.md Outdated Show resolved Hide resolved
README-pt.md Outdated Show resolved Hide resolved
i18n/pt.toml Outdated Show resolved Hide resolved
@tengqm tengqm added the language/pt Issues or PRs related to Portuguese language label Apr 15, 2019
OWNERS_ALIASES Outdated Show resolved Hide resolved
@jcjesus
Copy link
Contributor

jcjesus commented Apr 15, 2019 via email

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 16, 2019
@femrtnz
Copy link
Member Author

femrtnz commented Apr 16, 2019

Hi @raelga @remyleone,

Please let me know if there is anything else missing for this PR

@remyleone
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@remyleone
Copy link
Contributor

/assign @zacharysarah

@remyleone
Copy link
Contributor

@rlenferink Do you see something else? Could you approve this PR if it seems normal to you? :)

Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything else, we've got the initial setup covered in this PR ;)

Next steps

@femrtnz and @jcjesus, in the k/org repo please file an issue for k8s membership. More info here: https://kubernetes.io/docs/contribute/participating/#becoming-a-member

I'm happy to sponsor you and maybe @remyleone will chip in as well :)

After that, in the k/org repo, update sig-docs/teams.yaml with a PR to:

  • Add blocks for the owners and reviewers teams you created in OWNERS_ALIASES (example here).
  • Add the sig-docs-pt-owners individually to the sig-docs-l10n-admins team.
  • Add the sig-docs-pt-owners individually to the website-milestone-maintainers team.

/lgtm

/assign @zacharysarah
for approval

@zacharysarah
Copy link
Contributor

@femrtnz @jcjesus 👋 Thank you so much for starting this localization. The build preview looks great. ✨Welcome to Kubernetes! 🎉

@rlenferink @remyleone Thanks for providing reviews and guidance. 💛

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: remyleone, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit f1750f1 into kubernetes:master Apr 16, 2019
McCoyAle pushed a commit to McCoyAle/website that referenced this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants