Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Initial Portuguese Brazil translation. #13572

Closed
wants to merge 4 commits into from
Closed

WIP Initial Portuguese Brazil translation. #13572

wants to merge 4 commits into from

Conversation

jcjesus
Copy link
Contributor

@jcjesus jcjesus commented Apr 2, 2019

WIP - Initial Portuguese Brazil translation.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kbarnard10

If they are not already assigned, you can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@remyleone
Copy link
Contributor

/checkcla

@remyleone
Copy link
Contributor

You need to add a i18n/pt.toml file you can take example on the english one

- cstoku
- nasa9084
- tnir
- zacharysarah
sig-docs-ja-reviews: # PR reviews for Italian content
sig-docs-ja-reviews: # PR reviews for Italian content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware there is some whitespaces changes here

@remyleone
Copy link
Contributor

remyleone commented Apr 2, 2019

I think you can use only pt as it is the ISO 639-1 standard https://www.loc.gov/standards/iso639-2/php/code_list.php

@@ -0,0 +1,139 @@
# i18n strings for the English (main) site.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this comment


[languages.pt-BR]
title = "Kubernetes"
description = "Production-Grade Container Orchestration"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to translate it to Portuguese as well :)

make serve
```

This will start the local Hugo server on port 1313. Open up your browser to http://localhost:1313 to view the site. As you make changes to the source files, Hugo updates the site and forces a browser refresh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still English in this file

@zacharysarah
Copy link
Contributor

@jcjesus Thanks for beginning this localization!

@sieben Thank you for the helpful reviews. 🙇🏼‍♂️🌟

@zacharysarah
Copy link
Contributor

/check-cla

@zacharysarah
Copy link
Contributor

@jcjesus 👋 It looks like your CLA check is failing because the commits are attached to a different GitHub ID, julio.jesus. You can resolve it by rebasing all of your commits from @jcjesus.

# i18n strings for the English (main) site.

[deprecation_warning]
other = " documentação não será manutenida por mais tempo. A versão que você está visualizando atualmente é um versão desatualizada e estática. Para obter documentação atualizada, consulte "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mantida instead of manutenida ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, greate @femrtnz!

@@ -0,0 +1,13 @@
# See the OWNERS docs at https://go.k8s.io/owners

# This is the localization project for Portuguese Brazils.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to translate comments like that...

@@ -0,0 +1,13 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the folder to "pt" only, following the same folder structure as the older content.
e.g:
fr
en

@zacharysarah
Copy link
Contributor

Closing in favor of #13773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants