Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label for Polish language #15684

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Add label for Polish language #15684

merged 1 commit into from
Jan 13, 2020

Conversation

mfilocha
Copy link
Contributor

@mfilocha mfilocha commented Dec 23, 2019 •
edited
Loading

This PR adds the language/pl label for the k8s-docs being translated to Polish.

ref: kubernetes/website#18419

/cc @kubernetes/sig-contributor-experience-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @mfilocha!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mfilocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@mfilocha: Reiterating the mentions to trigger a notification:
@kubernetes/sig-contributor-experience-pr-reviews

In response to this:

This PR adds the language/pl label for the k8s-docs being translated to Polish.

ref: kubernetes/website#18254

/cc @kubernetes/sig-contributor-experience-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 23, 2019
@mfilocha
Copy link
Contributor Author

/assign @fejta

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2019
@idealhack
Copy link
Member

Could you please squash the commits? otherwise LGTM.

@mfilocha mfilocha force-pushed the add-labels-for-polish-language branch from 830d0ab to 54cadec Compare December 24, 2019 12:57
@mfilocha
Copy link
Contributor Author

@idealhack Commits have been squashed.

@idealhack
Copy link
Member

/lgtm
/assign @cblecker

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 25, 2019
@mfilocha mfilocha mentioned this pull request Dec 26, 2019
Closed
6 tasks
@remyleone
Copy link

@spiffxp Could you merge this one if @cblecker is not available?

@mfilocha mfilocha mentioned this pull request Dec 29, 2019
Closed
@cblecker
Copy link
Member

The PR to begin Polish localization efforts hasn't yet been approved. Sign off from a sig-docs lead is required.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@idealhack
Copy link
Member

/assign @jimangel

@mfilocha mfilocha mentioned this pull request Jan 3, 2020
Merged
fejta
fejta approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mfilocha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@mfilocha
Copy link
Contributor Author

mfilocha commented Jan 6, 2020

The bunch of PRs for the initial Polish translation is now targeted against the dev branch: https://github.com/kubernetes/website/milestone/40.
@cblecker, @fejta - Do you want to this PR to be merged after the first milestone is approved?

@cblecker
Copy link
Member

cblecker commented Jan 6, 2020

@mfilocha I don't have a preference as to the order, only that we need a SIG Docs lead to sign off on adding a new label for a new supported language.

@rlenferink
Copy link
Member

@cblecker The initial polish localization has been approved by @jimangel and announced by Zach on Slack. Is this enough to remove the /hold ?

Ref:
kubernetes/website#18419 (comment)
https://kubernetes.slack.com/archives/C1J0BPD2M/p1578905528152100

@mfilocha
Copy link
Contributor Author

@fejta

@cblecker The initial polish localization has been approved by @jimangel and announced by Zach on Slack. Is this enough to remove the /hold ?

Ref:
kubernetes/website#18419 (comment)
https://kubernetes.slack.com/archives/C1J0BPD2M/p1578905528152100

@cblecker
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 397eec8 into kubernetes:master Jan 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

@mfilocha: Updated the label-config configmap in namespace test-pods at cluster default using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

This PR adds the language/pl label for the k8s-docs being translated to Polish.

ref: kubernetes/website#18419

/cc @kubernetes/sig-contributor-experience-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfilocha mfilocha deleted the add-labels-for-polish-language branch January 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

Assignees

@idealhack idealhack

@fejta fejta

@cblecker cblecker

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
8 participants
@mfilocha @k8s-ci-robot @idealhack @remyleone @cblecker @rlenferink @fejta @jimangel