Update service load balancer finalizer doc for GA #17438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit fd3f98a https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dd58da640814000078d28bd |
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
language/en
|
/milestone 1.17 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Holding this until the k/k PR is merged. |
k8s-ci-robot
added
the
do-not-merge/hold
sftim
reviewed
Nov 6, 2019
| This feature is beta and enabled by default since Kubernetes v1.16. You can also | ||
| enable it in v1.15 (alpha) via the [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) | ||
| `ServiceLoadBalancerFinalizer`. | ||
| ### Feature availablity |
There was a problem hiding this comment.
I recommend using a feature state shortcode to indicate support. For example, add that shortcode on line 157 and move the text down.
One you've done that, the table of feature support here isn't needed.
If you mark this GA feature as stable since v1.17, readers who run (eg) v1.16 should have enough information to either switch to reading the v1.16 docs or to check the feature gate list.
There was a problem hiding this comment.
Thanks @sftim, that's a great suggestion. Updated to use feature state shortcode instead.
|
@MrHohn Just a reminder about the last Docs deadline - 22nd Nov, by which this PR needs to be merged! You have some review comments to be addressed. |
|
@daminisatya Oops, sorry this somehow falls off my radar. Updating this now, thanks! |
MrHohn
force-pushed
the
svc-finalizer-ga
branch
from
e7b71ba to
fd3f98a
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daminisatya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mrbobbytables
pushed a commit
that referenced
this pull request
Dec 6, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Dec 10, 2019
* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <[email protected]> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <[email protected]> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <[email protected]> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <[email protected]> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <[email protected]> * remove follow up placeholders Signed-off-by: Lachlan Evenson <[email protected]> * Update verbiage Signed-off-by: Lachlan Evenson <[email protected]> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <[email protected]> * Update to status.podIPs Signed-off-by: Lachlan Evenson <[email protected]> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <[email protected]> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <[email protected]> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <[email protected]> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <[email protected]> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubernetes/enhancements#980 (comment). Updating service load balancer finalizer doc to reflect the GA state.
cc @pgburt @daminisatya