Finalizer Protection for Service LoadBalancers

[MrHohn]

Enhancement Description

• One-line enhancement description (can be used as a release note): Adding finalizer protection to ensure the Service resource is not fully deleted until the correlating LB is also deleted.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190423-service-lb-finalizer.md
• Primary contact (assignee): @MrHohn
• Responsible SIGs:
  • @kubernetes/sig-network-feature-requests
  • @kubernetes/sig-cloud-provider-feature-requests
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.15)
  • Beta release target (1.16)
  • Stable release target (1.17)

[MrHohn]

/assign

[MrHohn]

More context on kubernetes/cloud-provider#16. Will send out a KEP soon.

@bowei @andrewsykim @jhorwit2 @jiatongw

[craiglpeters]

/milestone v1.15

[craiglpeters]

/label tracked/yes
/stage alpha

[craiglpeters]

@MrHohn, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[MrHohn]

@craiglpeters Thanks for the info. #992 should address the requirements.

[christianh814]

Hey @MrHohn I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[MrHohn]

@christianh814 Thanks for the reminder. Yep I think it will be worth to add new docs (or new paragraphs) for this. I will follow the timeline.

[MrHohn]

Created kubernetes/website#14496 as the placeholder PR for docs.

[craiglpeters]

Hi @MrHohn. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[MrHohn]

@craiglpeters Thanks for the reminder. Below are the open PRs. We will try to get the necessary ones merged before the freeze.

k/k:

• Feature implementation: Add Service Load Balancer finalizer support kubernetes#78262
• End-to-end tests: [e2e] Add tests for service load balancer finalizer kubernetes#78410

non k/k:

• Doc change: Add a section for service load balancer cleanup website#14496

[craiglpeters]

Hi @MrHohn, today is code freeze for the 1.15 release cycle. The k/k PRs have not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there high confidence these will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[MrHohn]

@craiglpeters Thanks for checking in. The only thing we are lacking at the moment is approval on kubernetes/kubernetes#78262. We will try to resolve that ASAP.

[kacole2]

Hi @MrHohn , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[MrHohn]

@kacole2 Sorry for the delay and thanks for the heads up. Yes we are looking to beta this feature in v1.16. I will make sure to list all relevant PRs once I have them.

[pgburt]

Hello @MrHohn , I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[MrHohn]

@pgburt Thanks for checking in. Yes this will require minor modifications to the existing doc. Would be great if you can point me to the Tracker Sheet or help me update that :)

[daminisatya]

Thank you @MrHohn I updated the tracking sheet. Kindly make sure you open the PR before 8th Nov. :D

[MrHohn]

Thanks @daminisatya, kubernetes/website#17438 is out for updating the doc.

[daminisatya]

awesome! @MrHohn Thank you

[kcmartin]

Hi @MrHohn

I am one of the Enhancements Shadows from the 1.17 Release Team. We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#81691 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link it here?

Thank you in advance 😄

[MrHohn]

@kcmartin Thanks for checking, yep there is one more PR for this:

• Promote service load balancer finalizer to GA kubernetes#85023

[kcmartin]

IMPORTANT PLEASE READ

Hi @MrHohn:
Tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[MrHohn]

@kcmartin Ack, I will ping the approver and try to get that merged ASAP.

[kcmartin]

@MrHohn Thank you, great to see the k/k PRs were merged!

[jeremyrickard]

Hey @MrHohn, 1.18 Enhancements lead here! Thanks for getting this into 1.17 and graduating to stable! I'm doing some cleanup on the issues that graduated and I noticed that your KEP is still marked as implementable. Could you please update the KEP to indicate that it was implemented and then we can close this issue out?

Thanks again, Happy New Year!

[MrHohn]

@jeremyrickard Sure thing, sent #1434 for this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[palnabarun]

Thank you @MrHohn for the efforts. 👍

Closing this since the KEP has been implemented.

/close

[k8s-ci-robot]

@palnabarun: Closing this issue.

In response to this:

Thank you @MrHohn for the efforts. 👍

Closing this since the KEP has been implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.