Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a section for service load balancer cleanup #14496

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Add a section for service load balancer cleanup #14496

merged 1 commit into from
Jun 11, 2019

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented May 23, 2019 •
edited
Loading

Ref kubernetes/enhancements#980 (comment), creating this PR as a placeholder for service load balancer finalizer docs.

Note this is not ready for review yet.
/hold

cc @christianh814

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 23, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 9e102b5

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5cfef04643ac7200070a1c78

@MrHohn MrHohn mentioned this pull request May 23, 2019
Closed
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 23, 2019
@makoscafee
Copy link
Contributor

/milestone 1.15

@k8s-ci-robot k8s-ci-robot added this to the 1.15 milestone May 29, 2019
@cmluciano
Copy link
Contributor

@MrHohn since the alpha PR has merged, will this also be cleaned up for 1.15?

@MrHohn
Copy link
Member Author

MrHohn commented Jun 6, 2019

@cmluciano Yes, sorry for the delay. I will finish up the PR today-ish.

@MrHohn MrHohn force-pushed the svc-lb-finalizer branch from 0b67a3d to c8acb6d Compare June 7, 2019 00:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2019
@MrHohn MrHohn changed the title [WIP] Placeholder for load balancer finalizer docs Add a section for service load balancer cleanup Jun 7, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2019
@MrHohn MrHohn force-pushed the svc-lb-finalizer branch from c8acb6d to 44ada79 Compare June 7, 2019 00:32
@MrHohn
Copy link
Member Author

MrHohn commented Jun 7, 2019

PR is ready for review now.
/hold cancel
/cc @andrewsykim @bowei

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim and bowei June 7, 2019 00:35
sftim
sftim reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informal feedback; I spotted a few things that are different from what the website style guide recommends.

content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md Outdated Show resolved Hide resolved
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md Outdated Show resolved Hide resolved
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md Outdated Show resolved Hide resolved
@MrHohn
Copy link
Member Author

MrHohn commented Jun 10, 2019

@sftim Thanks for the guidance and feedback. I pushed a new commit to address them.

andrewsykim
andrewsykim reviewed Jun 10, 2019
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit, LGTM otherwise

content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md Outdated Show resolved Hide resolved
@MrHohn MrHohn force-pushed the svc-lb-finalizer branch from f1fbcd3 to 9e102b5 Compare June 11, 2019 00:05
@andrewsykim
Copy link
Member

/lgtm

Thanks @MrHohn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2019
@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@jimangel jimangel merged commit c22345d into kubernetes:dev-1.15 Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@bprashanth bprashanth Awaiting requested review from bprashanth

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@bowei bowei Awaiting requested review from bowei

Assignees

@jimangel jimangel

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
8 participants
@MrHohn @k8sio-netlify-preview-bot @makoscafee @cmluciano @andrewsykim @jimangel @k8s-ci-robot @sftim