Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs/dualstack): v1.17 updates #17457

Merged
merged 9 commits into from
Nov 23, 2019
Merged

(docs/dualstack): v1.17 updates #17457

merged 9 commits into from
Nov 23, 2019

Conversation

lachie83
Copy link
Member

@lachie83 lachie83 commented Nov 6, 2019

1.17 docs updates for dualstack based on issues/563

Signed-off-by: Lachlan Evenson [email protected]

/milestone 1.17
/hold
/sig network

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17

For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh

For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@k8s-ci-robot
Copy link
Contributor

@lachie83: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

1.17 docs updates for dualstack based on issues/563

Signed-off-by: Lachlan Evenson [email protected]

/milestone 1.17
/hold
/sig network

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17

For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh

For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 6, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 6, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit f62820a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dd82a945734060008eaf8f1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2019
@lachie83 lachie83 mentioned this pull request Nov 6, 2019
Closed
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 6, 2019
@makoscafee
Copy link
Contributor

/milestone 1.17

@k8s-ci-robot k8s-ci-robot added this to the 1.17 milestone Nov 6, 2019
@irvifa
Copy link
Member

irvifa commented Nov 13, 2019

Hi @lachie83
I'm a docs release team shadow. This is a kind reminder since we're approaching the deadline for PR to be ready to be reviewed by Nov 15, 2019. Kindly update this PR, thanks a lot..

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2019
@lachie83 lachie83 changed the title [DO-NOT-MERGE] Placeholder doc update for 1.17 dualstack (docs/dualstack) v1.17 updates Nov 16, 2019
@lachie83 lachie83 changed the title (docs/dualstack) v1.17 updates (docs/dualstack): v1.17 updates Nov 16, 2019
@lachie83
Copy link
Member Author

@irvifa - This PR is ready for review.

@irvifa
Copy link
Member

irvifa commented Nov 16, 2019

Thank you so much mate!
/cc @daminisatya

@lachie83
Update to status.podIPs
4d303fe 
Signed-off-by: Lachlan Evenson <[email protected]>
@daminisatya
Copy link
Contributor

@lachie83 Just a reminder about the last Docs deadline - 22nd Nov, by which this PR needs to be merged!

@daminisatya
Copy link
Contributor

@lachie83 Can you please suggest a reviewer who can give a technical review done?

khenidak
khenidak reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@khenidak khenidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit.

content/en/docs/tasks/network/validate-dual-stack.md Outdated

The following command prints the value of the `MY_POD_IPS` environment variable from within a container. The value is a comma separated list that corresponds to the Pod's IPv4 and IPv6 addresses.
```shell
kubectl exec -it pod01 -- env | grep MY_POD_IPS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not:use set not env. AFIAK set is a builtin, env is not.

@khenidak
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@lachie83 @khenidak
Update content/en/docs/tasks/network/validate-dual-stack.md
f62820a 
Use set instead of env

Co-Authored-By: Khaled Henidak (Kal) <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@khenidak
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@daminisatya
Copy link
Contributor

thank you @khenidak for the review.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@lachie83
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e8444f into kubernetes:dev-1.17 Nov 23, 2019
mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019
@lachie83 @khenidak
(docs/dualstack): v1.17 updates (#17457)
5702296 
* Add placehold doc updates for dualstack in 1.17

Signed-off-by: Lachlan Evenson <[email protected]>

* Add Downward API and /etc/hosts Pod IP validation

Signed-off-by: Lachlan Evenson <[email protected]>

* remove addressed known issue via k/k pr 85246

Signed-off-by: Lachlan Evenson <[email protected]>

* Remove known issue and add flag as part of k/k 79993

Signed-off-by: Lachlan Evenson <[email protected]>

* remove follow up placeholders

Signed-off-by: Lachlan Evenson <[email protected]>

* Update verbiage

Signed-off-by: Lachlan Evenson <[email protected]>

* Make IP addressing consistent throughout the task

Signed-off-by: Lachlan Evenson <[email protected]>

* Update to status.podIPs

Signed-off-by: Lachlan Evenson <[email protected]>

* Update content/en/docs/tasks/network/validate-dual-stack.md

Use set instead of env

Co-Authored-By: Khaled Henidak (Kal) <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Dec 10, 2019
@daminisatya @k8s-ci-robot
Official 1.17 Release Docs (#18011)
dff2f7b 
* feat: graduate TaintNodesByCondition to GA (#17073)

* Promote StartupProbe to beta (enabled by default). (#17164)

* Watch bookmarks to GA (#17026)

* feat: graduate ScheduleDaemonSetPods to GA (#17350)

* Update Docker installation instructions (#17405)

* Use exact version numbers for installing Docker in Ubuntu (#17428)

* Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478)

* Promote NodeLease feature to GA (#17189)

* Update docs for csi topology ga (#17408)

* Update RunAsUsername to beta (#17460)

* doc:Update RunAsUsername to beta

* doc: update samples - kubernetes.io/os is no longer beta

* Updating based on review feedback

* Promote Node-specific volume limits to GA (#17432)

* Promote PodShareProcessNamespace to stable (#17192)

* Promote PodShareProcessNamespace to stable

* Add for_k8s_version to feature-state label

Co-Authored-By: Tim Bannister <[email protected]>

* Readd version-check to shareProcessNamespace task

* Update service load balancer finalizer doc for GA (#17438)

* Update Topology Manager docs (#17451)

* Added information on how device plugins can take advantage
of Topology Manager
* Updated the Topology Manager documentation to include additionalinformation and update some out of date sections

* Fix broken Topology Manager link (#17746)

Part of What's Next Device Plugin section

* Update CRD defaulting docs for GA (#17450)

* Add documentation for VolumeSnapshot Beta (#17233)

* Updating EndpointSlice documentation for beta release in 1.17 (#17411)

* (docs/dualstack): v1.17 updates (#17457)

* Add placehold doc updates for dualstack in 1.17

Signed-off-by: Lachlan Evenson <[email protected]>

* Add Downward API and /etc/hosts Pod IP validation

Signed-off-by: Lachlan Evenson <[email protected]>

* remove addressed known issue via k/k pr 85246

Signed-off-by: Lachlan Evenson <[email protected]>

* Remove known issue and add flag as part of k/k 79993

Signed-off-by: Lachlan Evenson <[email protected]>

* remove follow up placeholders

Signed-off-by: Lachlan Evenson <[email protected]>

* Update verbiage

Signed-off-by: Lachlan Evenson <[email protected]>

* Make IP addressing consistent throughout the task

Signed-off-by: Lachlan Evenson <[email protected]>

* Update to status.podIPs

Signed-off-by: Lachlan Evenson <[email protected]>

* Update content/en/docs/tasks/network/validate-dual-stack.md

Use set instead of env

Co-Authored-By: Khaled Henidak (Kal) <[email protected]>

* add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498)

Signed-off-by: Andrew Sy Kim <[email protected]>

* Service topology alpha documentation (#17459)

* Update list of feature flags for in-tree plugins migrated to CSI (#17533)

Signed-off-by: Deep Debroy <[email protected]>

* Update Node concept for TaintNodesByCondition going GA (#17577)

* feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554)

* kubeadm: update the upgrade documentation for 1.17 (#17587)

* doc: Simplify Windows deployments with RuntimeClass (#16697)

* doc: Simplify Windows deployments with RuntimeClass

* Updating on review feedback

* doc: Adding windows-build label from enhancement 1301

* update doc for kubelet option --reserved-cpus (#17648)

* feat: update TaintNodesByCondition in feature gates table (#17377)

* Update docs for v1 resource quota configuration (#17547)

* AdmissionConfiguration v1 (#17548)

* Update WebhookAdmissionConfiguration examples (#17549)

* Update AWS EBS Migration Feature state (#16126)

* Add resource version section to api-concepts documentation (#16910)

* Add Resource Version semantics section to api concepts

* Clarify risks of going back in time, add details about compaction and watch cache sizes

* Apply suggestions from liggitt

Co-Authored-By: Jordan Liggitt <[email protected]>

* remove pesudocode, apply feedback

* Fix typo

* Clarify equality rules

* Cleanup kubectl generators docs (#17609)

* Write ReplicationController without a space

* Drop mentioning unsupported cluster versions

* Fix capitalization for “API group”

* Tweak wording

* Avoid using deprecated generator in example

* add Antrea description in dev-1.17 (#17919)

* Promote VolumeSubpathEnvExpansion to GA

* Reference Documentation for the Kubernetes API for 1.17 (#18019)

* Update feature-gates.md (#18033)

* Reference Documentation for kubectl Commands for 1.17 (#18017)

* Update for v1.17 (#18034)

* Update config.toml(release-1.17) for 1.17 (#18031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khenidak khenidak khenidak left review comments

@aramase aramase aramase left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@daminisatya daminisatya

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
8 participants
@lachie83 @k8s-ci-robot @k8sio-netlify-preview-bot @makoscafee @irvifa @daminisatya @khenidak @aramase