Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.0 Redo Release #238

Merged
merged 77 commits into from
Mar 2, 2023
Merged

v0.7.0 Redo Release #238

merged 77 commits into from
Mar 2, 2023

Conversation

ktmeaton
Copy link
Owner

@ktmeaton ktmeaton commented Feb 28, 2023

v0.7.0 - Recursive Recombinants

Note: This is a redo of PR #232, where pushing my edits produced an unexpected merge commit.

Reviews

  • @ConnorChato

    • Pull Release Documentation reviewed.
    • Test Summary Package reviewed.
    • Tests (continuous integration) reviewed.
  • @TheZetner

    • Pull Release Documentation reviewed.
    • Test Summary Package reviewed.
    • Tests (continuous integration) reviewed.
  • @AndreaTy

    • Pull Release Documentation reviewed.
    • Test Summary Package reviewed.
    • Tests (continuous integration) reviewed.

Edits

  • @keaton:
    • Clarify the difference between a lineage and sublineage change.
    • Clarify what the node/lineage names mean in the sankey diagrams (ex. cluster_id)

Notes

This is a minor release aimed towards a nextclade dataset upgrade from 2022-10-27 to 2023-01-09 which adds nomenclature for newly designated recombinants XBH - XBP. This release also adds initial support for the detection of "recursive recombination" including XBL and XBN which are recombinants of XBB.

A comprehensive test summary report can be downloaded directly with: ncov-recombinant_v0.6.1_v0.7.0.zip or viewed at the following link once the release is complete.

Documentation

Dataset

Resources

sc2rf

  • Issue #195: Add bypass to intermission allele ratio for edge cases.
  • Issue #204: Add special handling for XBB sequenced with ARTIC v4.1 and dropout regions.
  • Issue #205: Add new column parents_conflict to indicate whether the reported lineages from covSPECTRUM conflict with the reported parental clades from `sc2rf.
  • Issue #213: Add XBK to auto-pass lineages.
  • Issue #222: Add new parameter --gisaid-access-key to sc2rf and sc2rf_recombinants.
  • Issue #229: Fix bug where auto-pass lineages are missing when exclude_negatives is set to true.
  • Issue #231: Fix bug where 'null' lineages in covSPECTRUM caused error in sc2rf postprocess.
  • The order of the postprocessing.py was rearranged to have more comprehensive details for auto-pass lineages.
  • Add XAN to auto-pass lineages.

Plot

  • Issue #209: Restrict the palette for rbd_level to the range of 0:12.
  • Issue #218: Fix bug concerning data fragmentation with large numbers of sequences.
  • Issue #221: Remove parameter --singletons in favor of --min-cluster-size to control cluster size in plots.
  • Issue #224: Fix bug where plot crashed with extremely large datasets.
  • Combine plot and plot_historical into one snakemake rule. Also at custom pattern plot_NX (ex. plot_N10) to adjust min cluster size.

Report

  • Combine report and report_historical into one snakemake rule.

Validate

  • Issue #225: Fix bug where false negatives passed validation because the status column wasn't checked.
Designated Lineages
Proposed Lineages

Continuous Integration

  • Issue #223: Change CI mamba version to fix setup-miniconda failure

Commits

Katherine Eaton added 30 commits November 10, 2022 11:49
add new param --min-cluster-size for #221
add new param --gisaid-access-key for #222
@ktmeaton ktmeaton changed the title v0.7.0 Redo Relese Redo v0.7.0 Redo Release Feb 28, 2023
@ktmeaton ktmeaton mentioned this pull request Feb 28, 2023
15 tasks
Copy link
Collaborator

@AndreaTy AndreaTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ktmeaton ktmeaton merged commit 400b11a into master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants