Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cloud resource metadata #185

Closed
6 tasks done
0x2b3bfa0 opened this issue Sep 5, 2021 · 7 comments · Fixed by #183, #187, #191, #193 or #190
Closed
6 tasks done

Support for cloud resource metadata #185

0x2b3bfa0 opened this issue Sep 5, 2021 · 7 comments · Fixed by #183, #187, #191, #193 or #190
Assignees
Labels
cloud-new New cloud support request discussion Waiting for team decision enhancement New feature or request

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 5, 2021

Epic for iterative/cml#430 provider-side support; follow-up to #3

Some vendors rely heavily on key/value metadata for resource management and, in some specific cases, permissions and policy enforcing. Most production–grade policies on vendors like AWS won't allow users to manage resources without proper creation–time tags.

Moreover, data science teams might also be interested in adding metadata to their cloud experiments for cost management and traceability purposes. See Kubeflow Metadata for a similar concept.

Implementation

Interface

Naming

  • metadata (subject to change)
  • labels
  • tags

Typing

  • map[string]string

Defaults

The official AWS provider supports default tags for all the created resources, but implementing this approach in a multicloud setting doesn't look like a good idea: every vendor uses labels/tags in a different way, and providing sensible defaults could be very difficult.

Example

resource "iterative_machine" "machine" {
  ···
  metadata = {
    project = "example"
    creator = "anybody"
  }
}

Requests

@DavidGOrtega
Copy link
Contributor

@0x2b3bfa0 Are we missing docs?

@0x2b3bfa0
Copy link
Member Author

@DavidGOrtega, yes, we're missing documentation and API propagation to:

@casperdcl
Copy link
Contributor

@0x2b3bfa0 does iterative/cml#750 need to be linked to this issue?

@dacbd
Copy link
Contributor

dacbd commented Oct 12, 2021

@0x2b3bfa0 does iterative/cml#750 need to be linked to this issue?

After a new version is published?/ then it should be good to move forward.

@0x2b3bfa0
Copy link
Member Author

Yes!

@0x2b3bfa0
Copy link
Member Author

Terraform-side support is complete. The only missing part is CML, that you have already implemented.

@dacbd
Copy link
Contributor

dacbd commented Oct 12, 2021

Terraform-side support is complete. The only missing part is CML, that you have already implemented.

I appreciate your help with all the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment