-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud metadata #748
Cloud metadata #748
Conversation
Leave environment variable management to yargs
@0x2b3bfa0 or @DavidGOrtega are you able to add a contrib branch and change the PR target while it is still marked as a draft? |
Updated based on: #430 (comment) |
Additionally, * Handle falsy values as empty strings * Simplify template code
Yes, we can. Would you like to merge it first to a |
@danielbarnes, counter–attacking with some suggestions and updated tests on dacbd#1. Feel free to review and merge that into your pull request. |
Update tests
I'm fine with 'owning' this patch should any changes be required but I'm still knocking off ~6yrs of nodejs rust and would prefer it lives on a branch here since upstream changes need to be published before it can really be tested. and I have a bad habit of blasting my own repos and re-forking things 😨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Merged into a separate branch. We'll release it after the Terraform provider. |
* Convert yargs builder function calls to plain objects Leave environment variable management to yargs * Remove dead code * Manage all the environment variables through yargs (#739) * Fix comment blunder * replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code Co-authored-by: Helio Machado <[email protected]> Co-authored-by: Daniel Barnes <[email protected]> Co-authored-by: davidgortega <[email protected]>
* replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code
* replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code Co-authored-by: Helio Machado <[email protected]>
Closes #430
Supercedes or Blocked by: #747
Requires upstream: iterative/terraform-provider-iterative#185
Manual testing:
./bin/cml.js runner \ --single \ --log=debug \ --idle-timeout=1800 \ --token=xxx \ --cloud=gcp \ --cloud-region=us-west \ --cloud-type=m \ --cloud-metadata="mykey=myval" \ --cloud-gpu=nogpu \ --repo=xxx \ --driver=github \ --cloud-hdd-size=10
Terraform template:
Test:
Terraform template: