-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud metadata #750
Cloud metadata #750
Conversation
* Convert yargs builder function calls to plain objects Leave environment variable management to yargs * Remove dead code * Manage all the environment variables through yargs (#739) * Fix comment blunder * replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code Co-authored-by: Helio Machado <[email protected]>
/tests |
Tested with GCP
|
@iterative/cml, I can't approve my own pull request, but it's ready for merging. |
Tested with aws:
|
@0x2b3bfa0 that's a job for you anyway |
@casperdcl, I'm not the release manager this week. 🙃 @DavidGOrtega, may I? |
…-barnes-cloud-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🙏🏼 Thanks for restoring the branch, @casperdcl. I'm deleting it again after fixing the merged commit. |
Pull request from #748 to
master
, to be released after iterative/terraform-provider-iterative#185