-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging of instances on AWS #430
Comments
👋 @ivyleavedtoadflax very good suggestion. Indeed Im changing the title to make it more assertive. No right now its not doing that but I agree that should be happening like the name is actually synced. |
Is there any update on this on? My use case is the following: I need to be able to see which resources relate to which project so that I can bill clients appropriately. Since we use tags for other AWS resources, it would make sense if we could use tags in this case, but in the interim I can use the instance labels. This adds an extra manual step for each client, so it would be good if I could avoid it! |
I am not sure of the status of this issue. I plan to attempt to implement this functionality unless a team member is actively developing it. In my use case, I need to add several tags 3-5 to all AWS resources for tracking/billing; If you can provide an example of how you would see this best passed to the cml-runner, I am willing to submit a PR here and upstream. I saw a previous upstream PR, but it looked like this only added specific tags and didn't allow users to add their own tags arbitrarily. |
Proposed syntax: Draftconst yargs = require("yargs");
function equalDelimitedToObject(items) {
const keyValuePairs = items.map((item) => [...item.split(/=(.+)/), null]);
return Object.fromEntries(keyValuePairs);
}
const options = {
"cloud-metadata": {
array: true,
string: true,
coerce: equalDelimitedToObject,
demandOption: true,
},
};
const { cloudMetadata } = yargs.strict().options(options).parse();
console.log(cloudMetadata); |
|
🔔 Carbon copy to @danielbarnes to avoid effort duplication. |
Glad you found the snippet above useful. It has been hidden as a comment in the edit history of #430 (comment) for a long time, just as a note to my future self. XKCD 1421. |
Is it possible to apply tags to instances created on AWS? I've tried the
--label
option, but I can't see where this is propagated into instances in AWS.The text was updated successfully, but these errors were encountered: