Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure metadata (tags) #191

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Add support for Azure metadata (tags) #191

merged 4 commits into from
Sep 10, 2021

Conversation

0x2b3bfa0
Copy link
Member

Part of #185

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cloud-new New cloud support request cloud-az Microsoft Azure labels Sep 5, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 5, 2021
@0x2b3bfa0 0x2b3bfa0 added resource-machine iterative_machine TF resource and removed cloud-new New cloud support request labels Sep 5, 2021
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Sep 5, 2021
6 tasks
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags does not seem to be created

image

Here is the file:

terraform {
  required_providers {
    iterative = {
      source = "github.com/iterative/iterative"
    }
  }
}

provider "iterative" {}

resource "iterative_cml_runner" "runner-gh-11" {
    metadata = {
      project = "example"
      creator = "anybody"
    }

    token = "XXX"
    repo = "XXX"
    driver = "gitlab"
    labels = "azure"
    idle_timeout = 0

    cloud = "azure"
    region = "us-west"
    instance_type = "Standard_F8s_v2"
    spot = true
    ssh_private = "XXX"
}

Im expecting to see project and creator tags

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 10, 2021

That's what I see when navigating to https://portal.azure.com/#blade/HubsExtension/TagsBlade, without running any terraform command:
Captura de pantalla 2021-09-10 a las 12 23 19

@DavidGOrtega
Copy link
Contributor

Not sure what do you mean. Can you please check that tags are created in your resources?
As far asI can state at least in the UI do not appear.

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 10, 2021

Not sure what do you mean. Can you please check that tags are created in your resources?
As far asI can state at least in the UI do not appear.

I mean that, after you ran terraform apply tags were created (globally) and you can see them at https://portal.azure.com/#blade/HubsExtension/TagsBlade and on every resource, as per my screenshot. I didn't even have to run terraform to see them, because you already did. 😄

The resource group itself, shown in your screenshot wasn't being tagged, but we can also tag it: see 896d1f3

Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@0x2b3bfa0 0x2b3bfa0 merged commit bed3f8a into master Sep 10, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the azure-metadata branch September 10, 2021 11:10
@0x2b3bfa0 0x2b3bfa0 linked an issue Sep 10, 2021 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-az Microsoft Azure enhancement New feature or request resource-machine iterative_machine TF resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for cloud resource metadata
3 participants