-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kubernetes metadata (labels+annotations) #189
Conversation
Setting up Azure Kubernetes ServiceInstalling the Azure command-line interface toolFirst of all, we need to install the Enabling experimental featuresIn order to automatically provision GPU nodes for our cluster, we'll also need to enable the following experimental features through the az extension add \
--name aks-preview
az provider register \
--namespace Microsoft.ContainerService
az feature register \
--namespace Microsoft.ContainerService \
--name GPUDedicatedVHDPreview Creating a test clusterThe following commands will create an AKS cluster with a single node, keeping everything into a a new resource group for easier deletion of the resources: az group create \
--name testKubernetesResourceGroup \
--location eastus az aks create \
--resource-group testKubernetesResourceGroup \
--name testKubernetesCluster \
--node-vm-size Standard_NC6 \
--node-count 1 \
--aks-custom-headers UseGPUDedicatedVHD=true Click to reveal a budget-friendly cluster configuration without GPU...az aks create \
--resource-group testKubernetesResourceGroup \
--name testKubernetesCluster \
--node-vm-size Standard_A2_v2 \
--node-count 1 Retrieving the credentialsAzure has some wrappers for Kubernetes authentication and will generate for us the required credentials. The following command will produce a full-fledged az aks get-credentials \
--resource-group testKubernetesResourceGroup \
--name testKubernetesCluster \
--file -
Deleting the test clusterOnce you've finished testing you can run the following command to delete the entire resource group, which includes the cluster and all its nodes: az group delete \
--name testKubernetesResourceGroup
|
Manual test report
|
It works as expected as per the manual and automated tests above, but this could be a good opportunity for reviewers (hello, reviewers) to play with Kubernetes and our Terraform provider. Feel free to take a look before merging. |
ping @iterative/cml |
ping @iterative/cml ++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
😅 🙏🏼 |
Part of #185
Labels can be used in queries and are also used for system metadata; annotations are for users, but can't be queried, so the solomonic solution was to use both.