Fix code review #13
Merged
Fix code review #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CxOne dev to release
Cxone dev
Merge dev to release - 21/04/23
…-library into cxone-dev-michael
* feat(gradle) support task list * Change parameter name to buildFlags to align with other piper steps'
Co-authored-by: Oliver Feldmann <[email protected]>
…ands (SAP#4310) * adding a timeout for helm test * extending test cases * Upadate the helmTestWaitSeconds parameter * Add timeout parameter for helm test command * Update tests --------- Co-authored-by: Vyacheslav Starostin <[email protected]>
* CodeQL compliance report and check * fix test cases --------- Co-authored-by: Daria Kuznetsova <[email protected]>
* DESS-1710: modified WaitForBuildToFinish function - added exception handling * DESS-1710: fixed parameters in WaitForBuildToFinish * DESS-1710: added error handling in WaitForBuildToFinish * DESS-1710: formatted build.go * DESS-1710: fixed error logging * DESS-1710: fixed Poll retrying * DESS-1710: renamed WaitForBuildToFinish * DESS-1710: refactored WaitForBuildToFinish * DESS-1710: changed maxRetries to 4 attempt * DESS-1710: fixed error handling --------- Co-authored-by: Christopher Fenner <[email protected]> Co-authored-by: Ashly Mathew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes