feat (kuberenetesDeploy) allow adding a timeout to the helm test commands

[anilkeshav27]

Changes

helm test command can now be made to wait with the param helmTestWaitSeconds . this gives a little more flexibility to allow long running test to complete before timing out

• Tests
• Documentation

[vstarostin]

After taking a look at the helm documentation I think this parameter is not necessary for the kubernetesDeploy step (at least for the current implementation of the step), since the step uses the —wait parameter for the helm upgrade command, which means that helm will not return until deploy is in a ready state --> the helm test command will not be started until previous one is done.

From helm docu regarding the wait param: will wait until all Pods, PVCs, Services, and minimum number of Pods of a Deployment, StatefulSet, or ReplicaSet are in a ready state before marking the release as successful. It will wait for as long as --timeout.
https://helm.sh/docs/helm/helm_upgrade/#:~:text=version%20is%20used-,%2D%2Dwait,-if%20set%2C%20will

I think the wait parameter for the helm test command is mainly used for waiting until deployment is in a ready state, after that tests can be triggered.
Since in our case the helm upgrade takes care of it, the wait param for the helm test is not necessary.

Do we have another reason to wait for the execution of the helm test besides waiting until deployment is in a ready state?

[anilkeshav27]

After taking a look at the helm documentation I think this parameter is not necessary for the kubernetesDeploy step (at least for the current implementation of the step), since the step uses the —wait parameter for the helm upgrade command, which means that helm will not return until deploy is in a ready state --> the helm test command will not be started until previous one is done.

From helm docu regarding the wait param: will wait until all Pods, PVCs, Services, and minimum number of Pods of a Deployment, StatefulSet, or ReplicaSet are in a ready state before marking the release as successful. It will wait for as long as --timeout. https://helm.sh/docs/helm/helm_upgrade/#:~:text=version%20is%20used-,%2D%2Dwait,-if%20set%2C%20will

I think the wait parameter for the helm test command is mainly used for waiting until deployment is in a ready state, after that tests can be triggered. Since in our case the helm upgrade takes care of it, the wait param for the helm test is not necessary.

Do we have another reason to wait for the execution of the helm test besides waiting until deployment is in a ready state?

Do we have another reason to wait for the execution of the helm test besides waiting until deployment is in a ready state?

its about when the test themselves run more than 300 seconds and not for the deployment to be in the ready state. Even when the deployment is in ready state , the test themselves can run more than 300s

[vstarostin]

its about when the test themselves run more than 300 seconds and not for the deployment to be in the ready state. Even when the deployment is in ready state , the test themselves can run more than 300s

ah...yes, sorry, I missed it.

[anilkeshav27]

@vstarostin , your changes looks good, could you please approve it, since i cannot approve my own changes

[vstarostin]

/it-go

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information