Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for integrationArtifactGetServiceEndpoint #4341

Merged
merged 1 commit into from
May 2, 2023

Conversation

alxsap
Copy link
Contributor

@alxsap alxsap commented May 2, 2023

Changes

In our tests often integrationArtifactGetServiceEndpoint fails with

info  integrationArtifactGetServiceEndpoint - [DEBUG] GET https://<address>/api/v1/ServiceEndpoints?$expand=EntryPoints
error integrationArtifactGetServiceEndpoint - a HTTP error occurred! Response body: , Response status code: 200

The reason is:
For some reason the "iflowID" (derived from the result.Name) does not match the "config.IntegrationFlowID". Therefore it does not return here.
Then the body is read a second time. And since it has already been read it is now empty. Therefore the strange error message.

  • Tests
  • Documentation

@alxsap alxsap requested a review from a team as a code owner May 2, 2023 14:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@o-liver o-liver enabled auto-merge (squash) May 2, 2023 14:32
@o-liver o-liver merged commit 70b09d6 into master May 2, 2023
@o-liver o-liver deleted the alxsap/pr/improveError branch May 2, 2023 14:34
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants