avoid log message pointing to http error in case the endpoint cannot … #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be retrieved from a 200 response body
|
Kudos, SonarCloud Quality Gate passed!
|
alxsap
deleted the
marcusholl/pr/loggingInsideIntegrationArtifactGetServiceEndpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be retrieved from a 200 response body
We have cases where the response body is empty but we still get an http-200 response code (side thread: why is that, should be investigated on the server-level).
The log message we get is confusing:
Error: Unable to get integration flow service endpoint, Response Status code: 200.With that change there will be a more precise message
Cannot retrieve integrationFlowServiceEndpoint from response: %qwhereqis the quoted response.Regarding the empty response which is currently shown with the error message I'm not sure. There are cases where a response can only be read once (depends on the http client). So maybe reading the response a second time (... as it was up to now) might be part of the problem.
Changes